Skip to content

starknet_transaction_prover: unify HTTP middleware stack via macro#14286

Open
avi-starkware wants to merge 1 commit into
main-v0.14.3from
avi/prover-v3/middleware-macro
Open

starknet_transaction_prover: unify HTTP middleware stack via macro#14286
avi-starkware wants to merge 1 commit into
main-v0.14.3from
avi/prover-v3/middleware-macro

Conversation

@avi-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@avi-starkware avi-starkware marked this pull request as ready for review June 1, 2026 11:22
@cursor
Copy link
Copy Markdown

cursor Bot commented Jun 1, 2026

PR Summary

Low Risk
Refactor-only: same middleware layers and order; no auth, TLS, or RPC behavior changes beyond deduplication.

Overview
Unifies the JSON-RPC HTTP middleware stack for plain HTTP (start_server) and HTTPS (tls::start_tls_server) behind a single prover_http_middleware! macro in server.rs, replacing two identical ServiceBuilder chains.

The macro keeps the same layer order (health outermost, OHTTP outside compression, body mapping around OHTTP). Rationale that lived in duplicated comments now lives on the macro, including why it must sit above pub mod tls for macro_rules! visibility in tls.rs.

Reviewed by Cursor Bugbot for commit f81df1e. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants