starknet_committer: name TrieReadTask lifetimes and document them#14239
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryLow Risk Overview No logic or API behavior changes—only naming and comments in Reviewed by Cursor Bugbot for commit bd2416b. Bugbot is set up for automated code reviews on this repo. Configure here. |
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
98f94f2 to
399a721
Compare
db78a3c to
9597670
Compare
Merge activity
|
9597670 to
c9b7fe9
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
The struct now uses 'indices / 'updates / 'storage instead of 'a / 'u / 's, and the doc comment explains why two non-storage lifetimes are needed: unifying them would make the returned OriginalSkeletonForest appear to borrow the storage update maps too, preventing the compute phase from moving those maps by value. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
c9b7fe9 to
bd2416b
Compare

The struct now uses 'indices / 'updates / 'storage instead of 'a / 'u /
's, and the doc comment explains why two non-storage lifetimes are
needed: unifying them would make the returned OriginalSkeletonForest
appear to borrow the storage update maps too, preventing the compute
phase from moving those maps by value.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com