Skip to content

deployment: add monitoring endpoint port to hybrid common overlay#14266

Merged
nimrod-starkware merged 1 commit into
main-v0.14.3from
05-31-deployment_add_monitoring_endpoint_port_to_hybrid_common_overlay
Jun 1, 2026
Merged

deployment: add monitoring endpoint port to hybrid common overlay#14266
nimrod-starkware merged 1 commit into
main-v0.14.3from
05-31-deployment_add_monitoring_endpoint_port_to_hybrid_common_overlay

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented May 31, 2026

Moves monitoring_endpoint_config.port from all hybrid environment overlays into the shared common overlay.

Devops counterpart (removal): https://github.com/starkware-industries/sequencer-devops/pull/751

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 31, 2026

PR Summary

Low Risk
Single config key moved to a shared overlay; no application logic or security behavior changes.

Overview
Centralizes hybrid sequencer monitoring configuration by setting monitoring_endpoint_config.port to 8082 in the shared hybrid/common overlay, aligning it with the existing monitoring-endpoint service port and metrics/probe paths.

Per-environment hybrid overlays no longer need to duplicate this setting (removed in the paired devops PR).

Reviewed by Cursor Bugbot for commit 909b4e0. Bugbot is set up for automated code reviews on this repo. Configure here.

@nimrod-starkware nimrod-starkware force-pushed the 05-31-deployment_add_monitoring_endpoint_port_to_hybrid_common_overlay branch from 8487873 to caea550 Compare May 31, 2026 13:41
@nimrod-starkware nimrod-starkware force-pushed the 05-31-deployment_add_http_server_port_to_hybrid_common_service_overlay branch from 4a045d0 to d8f8f77 Compare May 31, 2026 13:41
@nimrod-starkware nimrod-starkware force-pushed the 05-31-deployment_add_monitoring_endpoint_port_to_hybrid_common_overlay branch from caea550 to eaebc89 Compare May 31, 2026 13:49
@nimrod-starkware nimrod-starkware force-pushed the 05-31-deployment_add_http_server_port_to_hybrid_common_service_overlay branch from 50175d5 to fe1b892 Compare May 31, 2026 14:15
@nimrod-starkware nimrod-starkware force-pushed the 05-31-deployment_add_monitoring_endpoint_port_to_hybrid_common_overlay branch from eaebc89 to 18555e6 Compare May 31, 2026 14:15
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on nimrod-starkware).

@nimrod-starkware nimrod-starkware force-pushed the 05-31-deployment_add_http_server_port_to_hybrid_common_service_overlay branch from fe1b892 to 63c93e8 Compare June 1, 2026 08:15
@nimrod-starkware nimrod-starkware force-pushed the 05-31-deployment_add_monitoring_endpoint_port_to_hybrid_common_overlay branch 2 times, most recently from 2bbdc2a to da70927 Compare June 1, 2026 08:30
@nimrod-starkware nimrod-starkware force-pushed the 05-31-deployment_add_http_server_port_to_hybrid_common_service_overlay branch from 63c93e8 to d19c739 Compare June 1, 2026 08:30
@nimrod-starkware nimrod-starkware force-pushed the 05-31-deployment_add_monitoring_endpoint_port_to_hybrid_common_overlay branch from da70927 to cb76261 Compare June 1, 2026 10:06
@nimrod-starkware nimrod-starkware force-pushed the 05-31-deployment_add_monitoring_endpoint_port_to_hybrid_common_overlay branch from cb76261 to b665bc9 Compare June 1, 2026 12:50
@nimrod-starkware nimrod-starkware force-pushed the 05-31-deployment_add_http_server_port_to_hybrid_common_service_overlay branch 2 times, most recently from 8367aa1 to 88f1af8 Compare June 1, 2026 14:06
@nimrod-starkware nimrod-starkware force-pushed the 05-31-deployment_add_monitoring_endpoint_port_to_hybrid_common_overlay branch from b665bc9 to 0a847dd Compare June 1, 2026 14:06
@nimrod-starkware nimrod-starkware changed the base branch from 05-31-deployment_add_http_server_port_to_hybrid_common_service_overlay to graphite-base/14266 June 1, 2026 14:50
@nimrod-starkware nimrod-starkware force-pushed the 05-31-deployment_add_monitoring_endpoint_port_to_hybrid_common_overlay branch from 0a847dd to 909b4e0 Compare June 1, 2026 15:24
@graphite-app graphite-app Bot changed the base branch from graphite-base/14266 to main-v0.14.3 June 1, 2026 15:25
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jun 1, 2026

Merge activity

  • Jun 1, 3:25 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@nimrod-starkware nimrod-starkware added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main-v0.14.3 with commit 613f841 Jun 1, 2026
50 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants