Skip to content

scripts: add Committer to Service options#14304

Merged
matanl-starkware merged 1 commit into
mainfrom
matanl/prod-add-committer-service
Jun 3, 2026
Merged

scripts: add Committer to Service options#14304
matanl-starkware merged 1 commit into
mainfrom
matanl/prod-add-committer-service

Conversation

@matanl-starkware

Copy link
Copy Markdown
Collaborator

Add Committer to the Service enum, mapped to its StatefulSet resources
(sequencer-committer-config / sequencer-committer-statefulset-0), following the
Core pattern since the committer runs as a StatefulSet. It flows automatically
into the --service choices, help text, and converter.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@cursor

cursor Bot commented Jun 3, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Small extension to ops scripting enums and tests; no runtime sequencer or auth changes.

Overview
Adds Committer to the prod Service enum so production CLIs that take --service can target the committer workload. It maps to sequencer-committer-config and pod sequencer-committer-statefulset-0, matching the Core StatefulSet naming pattern. A unit test locks in those resource names and the existing enum round-trip behavior still covers the new member.

Reviewed by Cursor Bugbot for commit c7b1c92. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@ron-starkware ron-starkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ron-starkware reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on matanl-starkware).

@matanl-starkware matanl-starkware force-pushed the matanl/prod-clean-arg-help branch from 8b8ce98 to cf1868d Compare June 3, 2026 08:04
@matanl-starkware matanl-starkware force-pushed the matanl/prod-add-committer-service branch from 9fab39e to 1898d5c Compare June 3, 2026 08:04

@ron-starkware ron-starkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ron-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on matanl-starkware).

@matanl-starkware matanl-starkware force-pushed the matanl/prod-clean-arg-help branch from cf1868d to c0243c5 Compare June 3, 2026 08:29
@matanl-starkware matanl-starkware force-pushed the matanl/prod-add-committer-service branch from 1898d5c to a042263 Compare June 3, 2026 08:29
@matanl-starkware matanl-starkware force-pushed the matanl/prod-add-committer-service branch from a042263 to b82777d Compare June 3, 2026 08:36
@matanl-starkware matanl-starkware force-pushed the matanl/prod-clean-arg-help branch 2 times, most recently from 603bda9 to 3eda69b Compare June 3, 2026 11:56
@matanl-starkware matanl-starkware force-pushed the matanl/prod-add-committer-service branch from b82777d to 3833c63 Compare June 3, 2026 11:56
@matanl-starkware matanl-starkware force-pushed the matanl/prod-clean-arg-help branch from 3eda69b to c3e2607 Compare June 3, 2026 12:19
@matanl-starkware matanl-starkware force-pushed the matanl/prod-add-committer-service branch from 3833c63 to 6d1e138 Compare June 3, 2026 12:19
@matanl-starkware matanl-starkware force-pushed the matanl/prod-clean-arg-help branch from c3e2607 to e00fb67 Compare June 3, 2026 12:22
@matanl-starkware matanl-starkware force-pushed the matanl/prod-add-committer-service branch from 6d1e138 to 2248b90 Compare June 3, 2026 12:22
@matanl-starkware matanl-starkware force-pushed the matanl/prod-clean-arg-help branch from e00fb67 to 666fb9b Compare June 3, 2026 12:33
@matanl-starkware matanl-starkware force-pushed the matanl/prod-add-committer-service branch from 2248b90 to 22e9782 Compare June 3, 2026 12:34
@matanl-starkware matanl-starkware force-pushed the matanl/prod-clean-arg-help branch from 666fb9b to a31324f Compare June 3, 2026 13:50
@matanl-starkware matanl-starkware force-pushed the matanl/prod-add-committer-service branch from 22e9782 to 7fbf29b Compare June 3, 2026 13:50
@matanl-starkware matanl-starkware force-pushed the matanl/prod-add-committer-service branch from 7fbf29b to 6879a40 Compare June 3, 2026 14:00
@matanl-starkware matanl-starkware force-pushed the matanl/prod-clean-arg-help branch from a31324f to 438f50f Compare June 3, 2026 14:00
@matanl-starkware matanl-starkware force-pushed the matanl/prod-add-committer-service branch from 6879a40 to 6fcbcb6 Compare June 3, 2026 14:16
@matanl-starkware matanl-starkware force-pushed the matanl/prod-clean-arg-help branch 2 times, most recently from 38add1d to 5cb9f2b Compare June 3, 2026 17:46
@matanl-starkware matanl-starkware force-pushed the matanl/prod-add-committer-service branch from 6fcbcb6 to 53882ed Compare June 3, 2026 17:46
@matanl-starkware matanl-starkware force-pushed the matanl/prod-clean-arg-help branch from 5cb9f2b to c5eb3bc Compare June 3, 2026 18:01
@matanl-starkware matanl-starkware force-pushed the matanl/prod-add-committer-service branch from 53882ed to a53aaac Compare June 3, 2026 18:01
Add Committer to the Service enum, mapped to its StatefulSet resources
(sequencer-committer-config / sequencer-committer-statefulset-0), following the
Core pattern since the committer runs as a StatefulSet. It flows automatically
into the --service choices, help text, and converter.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@matanl-starkware matanl-starkware changed the base branch from matanl/prod-clean-arg-help to graphite-base/14304 June 3, 2026 21:15
@matanl-starkware matanl-starkware force-pushed the matanl/prod-add-committer-service branch from a53aaac to c7b1c92 Compare June 3, 2026 21:15
@matanl-starkware matanl-starkware changed the base branch from graphite-base/14304 to main June 3, 2026 21:15
@matanl-starkware

Copy link
Copy Markdown
Collaborator Author

@ron-starkware — next one 🙏 #14303 merged, so this rebased onto main and its Reviewable check reset. Re-approve this revision when you can? (Rebase only — no code changes since your prior approval.)

@matanl-starkware matanl-starkware added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main with commit 79fef74 Jun 3, 2026
19 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants