Skip to content

scripts: make --service a required argument#14306

Merged
matanl-starkware merged 1 commit into
mainfrom
matanl/prod-require-service
Jun 3, 2026
Merged

scripts: make --service a required argument#14306
matanl-starkware merged 1 commit into
mainfrom
matanl/prod-require-service

Conversation

@matanl-starkware

Copy link
Copy Markdown
Collaborator

Drop the implicit Service.Core default for --service in update_config_and_restart_nodes
and require it explicitly, so the targeted service is always a conscious choice
rather than silently defaulting to Core.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@cursor

cursor Bot commented Jun 3, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Operational CLI change only; scripts or runbooks that omitted -j will fail until updated, with no runtime auth or data-path impact.

Overview
The prod script update_config_and_restart_nodes.py no longer assumes Core when -j / --service is omitted: that flag is now required, and the help text no longer advertises a default.

Callers must pass the service explicitly (e.g. -j Core, -j Gateway), which avoids accidentally updating Core configmaps/pods when another service was intended.

Reviewed by Cursor Bugbot for commit 64e946b. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@ron-starkware ron-starkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ron-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on matanl-starkware).

@matanl-starkware matanl-starkware force-pushed the matanl/prod-confirm-core-all-at-once branch from 94e05b2 to dd039bc Compare June 3, 2026 08:04
@matanl-starkware matanl-starkware force-pushed the matanl/prod-require-service branch from 82068d6 to 85309ec Compare June 3, 2026 08:04

@ron-starkware ron-starkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ron-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on matanl-starkware).

@matanl-starkware matanl-starkware force-pushed the matanl/prod-confirm-core-all-at-once branch from dd039bc to 70ef243 Compare June 3, 2026 08:29
@matanl-starkware matanl-starkware force-pushed the matanl/prod-require-service branch from 85309ec to 5e3953c Compare June 3, 2026 08:29
@matanl-starkware matanl-starkware force-pushed the matanl/prod-confirm-core-all-at-once branch from 70ef243 to 3e6576d Compare June 3, 2026 08:36
@matanl-starkware matanl-starkware force-pushed the matanl/prod-require-service branch from 5e3953c to 057543a Compare June 3, 2026 08:36
@matanl-starkware matanl-starkware force-pushed the matanl/prod-confirm-core-all-at-once branch from 3e6576d to 2e2c13c Compare June 3, 2026 11:56
@matanl-starkware matanl-starkware force-pushed the matanl/prod-require-service branch from 057543a to 1591a09 Compare June 3, 2026 11:56
@matanl-starkware matanl-starkware force-pushed the matanl/prod-confirm-core-all-at-once branch from 2e2c13c to 70d97b5 Compare June 3, 2026 12:19
@matanl-starkware matanl-starkware force-pushed the matanl/prod-require-service branch from 1591a09 to 001bb2a Compare June 3, 2026 12:19
@matanl-starkware matanl-starkware force-pushed the matanl/prod-confirm-core-all-at-once branch from 70d97b5 to a10db9d Compare June 3, 2026 12:22
@matanl-starkware matanl-starkware force-pushed the matanl/prod-require-service branch from 001bb2a to 766fbfe Compare June 3, 2026 12:22
@matanl-starkware matanl-starkware force-pushed the matanl/prod-confirm-core-all-at-once branch from a10db9d to 85e7e78 Compare June 3, 2026 12:33
@matanl-starkware matanl-starkware force-pushed the matanl/prod-require-service branch from 766fbfe to 7d2891e Compare June 3, 2026 12:34
@matanl-starkware matanl-starkware force-pushed the matanl/prod-confirm-core-all-at-once branch from 85e7e78 to ab9529d Compare June 3, 2026 13:50
@matanl-starkware matanl-starkware force-pushed the matanl/prod-require-service branch from 7d2891e to 77afb5d Compare June 3, 2026 13:50
@matanl-starkware matanl-starkware force-pushed the matanl/prod-confirm-core-all-at-once branch from ab9529d to 5bca326 Compare June 3, 2026 14:00
@matanl-starkware matanl-starkware force-pushed the matanl/prod-require-service branch 2 times, most recently from 4751ac5 to af4288f Compare June 3, 2026 14:16
@matanl-starkware matanl-starkware force-pushed the matanl/prod-confirm-core-all-at-once branch 2 times, most recently from 7f0a1c0 to eb60175 Compare June 3, 2026 17:46
@matanl-starkware matanl-starkware force-pushed the matanl/prod-require-service branch 2 times, most recently from e924381 to f908c60 Compare June 3, 2026 18:01
@matanl-starkware matanl-starkware force-pushed the matanl/prod-confirm-core-all-at-once branch 2 times, most recently from 88d78e4 to e800f90 Compare June 3, 2026 21:15
@matanl-starkware matanl-starkware force-pushed the matanl/prod-require-service branch 2 times, most recently from 71ce1f5 to f873b12 Compare June 3, 2026 21:35
@matanl-starkware matanl-starkware force-pushed the matanl/prod-confirm-core-all-at-once branch from e800f90 to 526bd93 Compare June 3, 2026 21:35
Drop the implicit Service.Core default for --service in update_config_and_restart_nodes
and require it explicitly, so the targeted service is always a conscious choice
rather than silently defaulting to Core.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@matanl-starkware matanl-starkware changed the base branch from matanl/prod-confirm-core-all-at-once to graphite-base/14306 June 3, 2026 21:48
@matanl-starkware matanl-starkware force-pushed the matanl/prod-require-service branch from f873b12 to 64e946b Compare June 3, 2026 21:48
@matanl-starkware matanl-starkware changed the base branch from graphite-base/14306 to main June 3, 2026 21:48
@matanl-starkware

Copy link
Copy Markdown
Collaborator Author

@ron-starkware — last one in the stack 🙏 #14305 merged, so this rebased onto main and its Reviewable check reset. Re-approve this revision and we're done! (Rebase only — no code changes.)

@graphite-app

graphite-app Bot commented Jun 3, 2026

Copy link
Copy Markdown

Merge activity

  • Jun 3, 9:49 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@matanl-starkware matanl-starkware added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main with commit b1aef2b Jun 3, 2026
18 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants