scripts: make --service a required argument#14306
Conversation
PR SummaryLow Risk Overview Callers must pass the service explicitly (e.g. Reviewed by Cursor Bugbot for commit 64e946b. Bugbot is set up for automated code reviews on this repo. Configure here. |
ron-starkware
left a comment
There was a problem hiding this comment.
@ron-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on matanl-starkware).
94e05b2 to
dd039bc
Compare
82068d6 to
85309ec
Compare
ron-starkware
left a comment
There was a problem hiding this comment.
@ron-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on matanl-starkware).
dd039bc to
70ef243
Compare
85309ec to
5e3953c
Compare
70ef243 to
3e6576d
Compare
5e3953c to
057543a
Compare
3e6576d to
2e2c13c
Compare
057543a to
1591a09
Compare
2e2c13c to
70d97b5
Compare
1591a09 to
001bb2a
Compare
70d97b5 to
a10db9d
Compare
001bb2a to
766fbfe
Compare
a10db9d to
85e7e78
Compare
766fbfe to
7d2891e
Compare
85e7e78 to
ab9529d
Compare
7d2891e to
77afb5d
Compare
ab9529d to
5bca326
Compare
4751ac5 to
af4288f
Compare
7f0a1c0 to
eb60175
Compare
e924381 to
f908c60
Compare
88d78e4 to
e800f90
Compare
71ce1f5 to
f873b12
Compare
e800f90 to
526bd93
Compare
Drop the implicit Service.Core default for --service in update_config_and_restart_nodes and require it explicitly, so the targeted service is always a conscious choice rather than silently defaulting to Core. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
526bd93 to
ebf6d8b
Compare
f873b12 to
64e946b
Compare
|
@ron-starkware — last one in the stack 🙏 #14305 merged, so this rebased onto |
Merge activity
|

Drop the implicit Service.Core default for --service in update_config_and_restart_nodes
and require it explicitly, so the targeted service is always a conscious choice
rather than silently defaulting to Core.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com