Skip to content

starknet_os: resources test - deploy account#14416

Open
dorimedini-starkware wants to merge 1 commit into
06-08-starknet_os_resources_test_-_declarefrom
06-08-starknet_os_resources_test_-_deploy_account
Open

starknet_os: resources test - deploy account#14416
dorimedini-starkware wants to merge 1 commit into
06-08-starknet_os_resources_test_-_declarefrom
06-08-starknet_os_resources_test_-_deploy_account

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor

cursor Bot commented Jun 8, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test and versioned-constants snapshot updates only; no runtime execution-path changes beyond refreshed fee/resource accounting constants.

Overview
Extends test_execute_txs_inner_resources so DeployAccount is measured the same way as invoke/declare: two deploy-account txs (minimal vs extra constructor calldata) to derive constant and scaled calldata-factor overhead, with addresses funded in a prior block to keep the measurement block clean.

The test now writes DeployAccount into execute_txs_inner on the latest versioned constants snapshot. blockifier_versioned_constants_0_14_4.json is updated with the new measured DeployAccount constant costs (e.g. 4989 steps, adjusted builtin counts). The 0.14.3→0.14.4 VC diff regression file gains the corresponding DeployAccount lines, and blob_file_generation bumps 35 → 36.

Reviewed by Cursor Bugbot for commit ff4a53a. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from 124e469 to de0acc0 Compare June 8, 2026 11:02
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch from f8574a1 to b75dab6 Compare June 8, 2026 11:02
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from de0acc0 to fa76fed Compare June 8, 2026 11:59
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch 2 times, most recently from f253770 to c156411 Compare June 9, 2026 11:37
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch 2 times, most recently from 78fae78 to e99d6e3 Compare June 9, 2026 12:01
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch 2 times, most recently from 8586934 to 65f48cb Compare June 9, 2026 12:25
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch 2 times, most recently from d40f936 to a55cb17 Compare June 9, 2026 13:06
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch from 65f48cb to 0906746 Compare June 9, 2026 13:06
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from a55cb17 to 0dec088 Compare June 11, 2026 13:05
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch from 0906746 to d923bac Compare June 11, 2026 13:05
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from 0dec088 to ce08f52 Compare June 11, 2026 16:58
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch from d923bac to 95e014c Compare June 11, 2026 16:58
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from ce08f52 to 79997f7 Compare June 13, 2026 15:34
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch from 95e014c to ff4a53a Compare June 13, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants