Skip to content

starknet_os: resources test - declare#14415

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factorfrom
06-08-starknet_os_resources_test_-_declare
Open

starknet_os: resources test - declare#14415
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factorfrom
06-08-starknet_os_resources_test_-_declare

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

dorimedini-starkware commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor

cursor Bot commented Jun 8, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test and versioned-constant snapshot updates driven by OS resource measurement; no production execution-path logic changes.

Overview
Extends test_execute_txs_inner_resources to run a third Declare transaction (using the stable DATA_GAS_ACCOUNT class) and record the OS-only overhead under execute_txs_inner.Declare.

Versioned constants for 0.14.4 are updated with the measured Declare scaffolding cost (3938 steps, 92 range-check builtins, plus pedersen/poseidon), and the 0.14.3→0.14.4 diff regression file picks up those lines.

Supporting fixture churn: the resource-measurement deployable account gains __validate_declare__ with refreshed Sierra/CASM artifacts; the OS resources test contract uses deploy salt 3 for deterministic deploy syscall costs; central systest blob/preconfirmed JSON values shift from regenerated runs.

Reviewed by Cursor Bugbot for commit 79997f7. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from 124e469 to de0acc0 Compare June 8, 2026 11:02
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factor branch from 7f07092 to fb53fd2 Compare June 8, 2026 11:59
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch 3 times, most recently from 78fae78 to e99d6e3 Compare June 9, 2026 12:01
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factor branch from 214c8b8 to e5e710c Compare June 9, 2026 12:01
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from e99d6e3 to d40f936 Compare June 9, 2026 12:25

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).


crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 107 at r1 (raw file):

        deploy_syscall(stable_class_hash, 3, array![0].span(), true).unwrap_syscall();
        // linear factor (calldata len = 1):
        deploy_syscall(stable_class_hash, 3, array![1, 0].span(), true).unwrap_syscall();

the stable contract changed, so the magic salt that hits the same Deploy resources must also change

Code quote:

        deploy_syscall(stable_class_hash, 3, array![0].span(), true).unwrap_syscall();
        // linear factor (calldata len = 1):
        deploy_syscall(stable_class_hash, 3, array![1, 0].span(), true).unwrap_syscall();

@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from d40f936 to a55cb17 Compare June 9, 2026 13:06
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factor branch from e5e710c to fad008d Compare June 11, 2026 13:05
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch 2 times, most recently from 0dec088 to ce08f52 Compare June 11, 2026 16:58
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from ce08f52 to 79997f7 Compare June 13, 2026 15:34
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factor branch from 1664e0f to 904bec6 Compare June 13, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants