starknet_os: resources test - declare#14415
Conversation
PR SummaryLow Risk Overview Versioned constants for 0.14.4 are updated with the measured Declare scaffolding cost (3938 steps, 92 range-check builtins, plus pedersen/poseidon), and the 0.14.3→0.14.4 diff regression file picks up those lines. Supporting fixture churn: the resource-measurement deployable account gains Reviewed by Cursor Bugbot for commit 79997f7. Bugbot is set up for automated code reviews on this repo. Configure here. |
124e469 to
de0acc0
Compare
7f07092 to
fb53fd2
Compare
78fae78 to
e99d6e3
Compare
214c8b8 to
e5e710c
Compare
e99d6e3 to
d40f936
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).
crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 107 at r1 (raw file):
deploy_syscall(stable_class_hash, 3, array![0].span(), true).unwrap_syscall(); // linear factor (calldata len = 1): deploy_syscall(stable_class_hash, 3, array![1, 0].span(), true).unwrap_syscall();
the stable contract changed, so the magic salt that hits the same Deploy resources must also change
Code quote:
deploy_syscall(stable_class_hash, 3, array![0].span(), true).unwrap_syscall();
// linear factor (calldata len = 1):
deploy_syscall(stable_class_hash, 3, array![1, 0].span(), true).unwrap_syscall();d40f936 to
a55cb17
Compare
e5e710c to
fad008d
Compare
0dec088 to
ce08f52
Compare
ce08f52 to
79997f7
Compare
1664e0f to
904bec6
Compare

No description provided.