starknet_committer,starknet_os: relocate commitment infos to starknet_committer

[itamar-starkware]

No description provided.

[itamar-starkware]

• apollo_storage: add state_commitment_infos table #14448
• starknet_committer,starknet_os: relocate commitment infos to starknet_committer #14447 👈 (View in Graphite)
• starknet_os: convert StateCommitmentInfos::new into a free function #14488
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[itamar-starkware]

Why this PR exists

Second in the stack (#14446 → #14447 → #14448). The goal is to persist StateCommitmentInfos in apollo_storage (#14448) and, later, have the committer produce it.

CommitmentInfo / StateCommitmentInfos currently live in starknet_os. But the components that need to store/produce them — apollo_storage, and later the committer — sit below the OS. If the structs stayed in starknet_os, those lower layers would have to depend on starknet_os: a backwards dependency.

So this PR relocates the two structs down to starknet_committer (right next to StarknetForestProofs), starknet_os re-exports them so all OS consumers are unaffected, and adds the serde / Clone / PartialEq derives the storage layer needs. Because the struct now lives in another crate, Rust's orphan rule forbids keeping the inherent StateCommitmentInfos::new builder in starknet_os, so it becomes a free function build_state_commitment_infos (kept in starknet_os, marked temporary — to be removed once the committer builds the infos from its own storage).

This does not change the dependency graph:

• starknet_os already depends on starknet_committer (commitment_infos.rs imports fetch_previous_and_new_patricia_paths, RootHashes, get_leaves, … from it), so the move is "downhill" — no new or reversed edge.
• The structs are defined over low-level types only (HashOutput, SubTreeHeight, ContractAddress, Felt), all of which starknet_committer already depends on — so starknet_committer gains no dependency on starknet_os.
• Downstream, this is exactly what avoids a bad edge: the committer can build/return these types and apollo_storage can store them, both via their existing starknet_committer dependency — neither acquires a starknet_os dependency.

Unblocks #14448.

[yoavGrs]

@yoavGrs reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on itamar-starkware).

---

crates/starknet_os/src/commitment_infos.rs line 39 at r1 (raw file):

/// Creates the commitment infos for the OS from previous and new state roots and the
/// keys that were read during execution.
// TODO: Temporary — to be deleted once the committer builds `StateCommitmentInfos` from its own

a. Do you plan to change the OS test to use the new committer's API?
b. Assign yourself to the TODO?

Code quote:

TODO: Temporary 

[itamar-starkware]

Thanks @yoavGrs! Addressed both:

a. Yes — once the committer exposes the new StateCommitmentInfos API (your upcoming PR), the OS flow test (test_manager.rs) and the prover (storage_proofs.rs) will switch to it and build_state_commitment_infos gets deleted. We'll add tests against the new committer API at that point.

b. Done — assigned the TODO to me: // TODO(ItamarS): Temporary — … (in the updated commit).

[yoavGrs]

@yoavGrs reviewed 4 files and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on itamar-starkware).

[graphite-app]

Merge activity

• Jun 14, 11:02 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
• Jun 14, 12:57 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[yoavGrs]

Add apollo_storage to the tests in .github/workflows/apollo_storage_os_input_ci.yml

[yoavGrs]

Add apollo_storage to the tests in .github/workflows/apollo_storage_os_input_ci.yml

[itamar-starkware]

It's already inside this yaml

[yoavGrs]

@yoavGrs reviewed 9 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on itamar-starkware).