Skip to content

apollo_storage: add state_commitment_infos table#14448

Merged
itamar-starkware merged 1 commit into
mainfrom
apollo_storage_state_commitment_infos_table
Jun 14, 2026
Merged

apollo_storage: add state_commitment_infos table#14448
itamar-starkware merged 1 commit into
mainfrom
apollo_storage_state_commitment_infos_table

Conversation

@itamar-starkware

@itamar-starkware itamar-starkware commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@itamar-starkware itamar-starkware mentioned this pull request Jun 10, 2026
Merged
@itamar-starkware Graphite App

itamar-starkware commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@itamar-starkware itamar-starkware mentioned this pull request Jun 10, 2026
Merged
@reviewable-StarkWare

reviewable-StarkWare commented Jun 10, 2026

Copy link
Copy Markdown

This change is Reviewable

@github-actions

github-actions Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Artifacts upload workflows:

@itamar-starkware itamar-starkware marked this pull request as ready for review June 10, 2026 12:32
@itamar-starkware

itamar-starkware commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Why this PR exists

Top of the stack (#14446 → #14447 → #14448), and part of the larger effort to feed the Starknet-OS proving input into the cende blob.

The committer will hand the OS the cooked StateCommitmentInfos (the three per-trie CommitmentInfos the OS consumes) instead of raw witnesses, and the batcher must persist them so consensus can later read them and attach them to the blob. This PR adds the storage half: a per-block state_commitment_infos mmap table in apollo_storage, mirroring the existing accessed_keys table — reader / writer / revert traits, a MAX_DBS bump, a new OffsetKind, and serde via serde_json + compress (correct here, since StateCommitmentInfos uses normal derived serde). All gated behind os_input.

Depends on #14447 (the relocated, serializable struct) and #14446 (SubTreeHeight serde). The committer-side builder of StateCommitmentInfos and the consensus/blob consumer are separate, follow-up work.

@itamar-starkware itamar-starkware requested a review from yoavGrs June 10, 2026 14:00
@itamar-starkware itamar-starkware force-pushed the starknet_committer_relocate_commitment_infos branch from 9f39c98 to 8df0e9b Compare June 10, 2026 15:29
@itamar-starkware itamar-starkware force-pushed the apollo_storage_state_commitment_infos_table branch from eb33782 to 4299383 Compare June 10, 2026 15:29
yoavGrs
yoavGrs approved these changes Jun 11, 2026
View reviewed changes

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 7 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on itamar-starkware).

@itamar-starkware itamar-starkware force-pushed the apollo_storage_state_commitment_infos_table branch from 4299383 to 8fc931b Compare June 11, 2026 07:09
@itamar-starkware itamar-starkware force-pushed the starknet_committer_relocate_commitment_infos branch from 8df0e9b to 2923883 Compare June 11, 2026 07:09
@itamar-starkware itamar-starkware force-pushed the apollo_storage_state_commitment_infos_table branch from 8fc931b to f1df4bd Compare June 11, 2026 10:02
@itamar-starkware itamar-starkware force-pushed the starknet_committer_relocate_commitment_infos branch from 2923883 to c64de43 Compare June 11, 2026 10:02
yoavGrs
yoavGrs approved these changes Jun 11, 2026
View reviewed changes

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on itamar-starkware).

yoavGrs
yoavGrs requested changes Jun 11, 2026
View reviewed changes
Comment thread crates/apollo_storage/src/state_commitment_infos.rs Outdated
@itamar-starkware itamar-starkware force-pushed the apollo_storage_state_commitment_infos_table branch from f1df4bd to 992e48a Compare June 11, 2026 19:31
@itamar-starkware itamar-starkware force-pushed the starknet_committer_relocate_commitment_infos branch 2 times, most recently from 7cf9b7e to b3c49bb Compare June 13, 2026 21:23
@itamar-starkware itamar-starkware force-pushed the apollo_storage_state_commitment_infos_table branch from 992e48a to 2558baf Compare June 13, 2026 21:23
@itamar-starkware itamar-starkware force-pushed the starknet_committer_relocate_commitment_infos branch from b3c49bb to 247fbd5 Compare June 13, 2026 22:50
@itamar-starkware itamar-starkware force-pushed the apollo_storage_state_commitment_infos_table branch from 2558baf to a1f5190 Compare June 13, 2026 22:50
@itamar-starkware itamar-starkware force-pushed the starknet_committer_relocate_commitment_infos branch from 247fbd5 to c728652 Compare June 13, 2026 23:12
@itamar-starkware itamar-starkware force-pushed the apollo_storage_state_commitment_infos_table branch from a1f5190 to 65035ac Compare June 13, 2026 23:12
@itamar-starkware itamar-starkware force-pushed the starknet_committer_relocate_commitment_infos branch from c728652 to e6f6485 Compare June 14, 2026 11:01
@itamar-starkware itamar-starkware force-pushed the apollo_storage_state_commitment_infos_table branch from 65035ac to 7a0fdb3 Compare June 14, 2026 11:01
@graphite-app graphite-app Bot changed the base branch from starknet_committer_relocate_commitment_infos to graphite-base/14448 June 14, 2026 11:01
@itamar-starkware itamar-starkware mentioned this pull request Jun 14, 2026
Merged
@itamar-starkware itamar-starkware force-pushed the apollo_storage_state_commitment_infos_table branch from 7a0fdb3 to 54cf235 Compare June 14, 2026 11:59
@itamar-starkware itamar-starkware changed the base branch from graphite-base/14448 to starknet_committer_relocate_commitment_infos June 14, 2026 11:59
@itamar-starkware itamar-starkware force-pushed the apollo_storage_state_commitment_infos_table branch from 54cf235 to 559e3ad Compare June 14, 2026 12:30
@graphite-app graphite-app Bot changed the base branch from starknet_committer_relocate_commitment_infos to graphite-base/14448 June 14, 2026 12:56
@itamar-starkware itamar-starkware force-pushed the apollo_storage_state_commitment_infos_table branch from 559e3ad to 1c2ef14 Compare June 14, 2026 14:34
@itamar-starkware itamar-starkware changed the base branch from graphite-base/14448 to main June 14, 2026 14:34
yoavGrs
yoavGrs approved these changes Jun 14, 2026
View reviewed changes

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 6 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on itamar-starkware).

Comment thread crates/apollo_storage/src/state_commitment_infos.rs Outdated
@itamar-starkware itamar-starkware added this pull request to the merge queue Jun 14, 2026
Merged via the queue into main with commit 6fdd21e Jun 14, 2026
47 of 119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoavGrs yoavGrs yoavGrs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itamar-starkware @reviewable-StarkWare @yoavGrs