Generic Merkle Channel in Prover

[Gali-StarkWare]

No description provided.

[reviewable-StarkWare]

This change is 

[Gali-StarkWare]

• Cairo Serde #467
• Generic Merkle Channel in Prover #466 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ilyalesokhin-starkware]

crates/circuit_prover/src/prover.rs line 42 at r1 (raw file):

const COMPOSITION_POLYNOMIAL_LOG_DEGREE_BOUND: u32 = 1;

pub struct CircuitProof<H: MerkleHasherLifted = Blake2sM31MerkleHasher> {

What happens if you don't give a default?

Suggestion:

<H: MerkleHasherLifted>

[ilyalesokhin-starkware]

@ilyalesokhin-starkware reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Gali-StarkWare).

[Gali-StarkWare]

@Gali-StarkWare made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ilyalesokhin-starkware).

---

crates/circuit_prover/src/prover.rs line 42 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

What happens if you don't give a default?

Done.

[ilyalesokhin-starkware]

@ilyalesokhin-starkware reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Gali-StarkWare).