Cairo Serde

[Gali-StarkWare]

No description provided.

[reviewable-StarkWare]

This change is 

[Gali-StarkWare]

• Cairo Serde #467 👈 (View in Graphite)
• Generic Merkle Channel in Prover #466
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ilyalesokhin-starkware]

CLAUDE.md line 123 at r2 (raw file):

# Verifier stable check (must compile on stable 1.88.0)
RUSTUP_TOOLCHAIN=1.88.0 cargo check --workspace \
  --exclude circuit-prover --exclude circuit-cairo-serialize --exclude circuits-stark-verifier-examples

why?

Code quote:

--exclude circuit-cairo-serialize

[ilyalesokhin-starkware]

crates/circuit_cairo_serialize/src/proof.rs line 35 at r2 (raw file):

// not implement them. Roundtrip tests compare serialized bytes instead.
#[derive(Clone, Debug, CairoSerialize, CairoDeserialize)]
pub struct CairoCircuitProof<H: MerkleHasherLifted<Hash = Blake2sHash> = Blake2sM31MerkleHasher> {

remove

Code quote:

= Blake2sM31MerkleHasher

[ilyalesokhin-starkware]

crates/circuit_cairo_serialize/src/proof.rs line 48 at r2 (raw file):

#[derive(Clone, Debug, CairoSerialize, CairoDeserialize)]
pub struct CairoStarkProofForCircuit<
    H: MerkleHasherLifted<Hash = Blake2sHash> = Blake2sM31MerkleHasher,

Suggestion:

<Hash> 

[ilyalesokhin-starkware]

crates/circuit_cairo_serialize/src/proof.rs line 128 at r2 (raw file):

) -> Result<Vec<FieldElement>, &'static str> {
    let proof = CairoCircuitProof::<H>::from_prover_output(prover_output)?;
    let mut bytes = Vec::new();

Suggestion:

 let mut felts = Vec::new();

[ilyalesokhin-starkware]

crates/circuit_cairo_serialize/src/proof.rs line 13 at r2 (raw file):

use cairo_air::utils::sort_and_transpose_queried_values;
use circuit_prover::prover::CircuitProof as CircuitProverOutput;

maybe rename CircuitProof in a preliminary PR?

Code quote:

use circuit_prover::prover::CircuitProof as CircuitProverOutput;

[ilyalesokhin-starkware]

crates/circuit_cairo_serialize/src/proof.rs line 144 at r2 (raw file):

    let mut interaction = Vec::new();
    for component in &prover_output.components {
        let bounds: TreeVec<ColumnVec<u32>> = component.trace_log_degree_bounds();

Suggestion:

  let bounds: TreeVec<ColumnVec<u32>> = component.trace_log_degree_bounds();
  let Some([_, trace_log_size, interaction_log_size]) = bounds.try_into() else {
      panic!("Unexpected trace_log_degree_bounds length");
  }

[ilyalesokhin-starkware]

crates/circuit_cairo_serialize/src/test.rs line 28 at r2 (raw file):

/// Builds a tiny but real circuit assignment so we can run the prover and get a
/// well-formed `CircuitProof` to round-trip. Same shape as the Fibonacci context used

what does that mean?

Code quote:

to round-trip

[ilyalesokhin-starkware]

crates/circuit_cairo_serialize/src/test.rs line 63 at r2 (raw file):

    // re-serialized bytes — if the deserializer is the inverse of the serializer, the
    // two byte streams must match.
    let mut bytes = Vec::new();

felts

Code quote:

bytes

[ilyalesokhin-starkware]

crates/circuit_cairo_serialize/src/test.rs line 28 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

what does that mean?

for serde round-trip test

[ilyalesokhin-starkware]

crates/circuit_cairo_serialize/src/config.rs line 10 at r2 (raw file):

#[derive(Clone, Debug, PartialEq, Eq, CairoSerialize, CairoDeserialize)]
pub struct CairoCircuitVerifierConfig {

What is this struct? is it related to CircuitConfig?

Code quote:

CairoCircuitVerifierConfig