Remove log_sizes field from CircuitClaim#477
Remove log_sizes field from CircuitClaim#477ilyalesokhin-starkware wants to merge 1 commit intoilya/log_sizesfrom
Conversation
PR SummaryMedium Risk Overview The prover now computes Reviewed by Cursor Bugbot for commit e4899a5. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Component log sizes are fixed given the CircuitConfig, so derive them from the preprocessed trace at proving time and route them through the Cairo Statement's claims_to_mix rather than mixing them via CircuitClaim::mix_into.
5ac7d02 to
e4899a5
Compare
879b009 to
ce255e1
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e4899a5. Configure here.
| use crate::relations::{BLAKE_STATE_RELATION_ID, CommonLookupElements, GATE_RELATION_ID}; | ||
| use circuits::ivalue::qm31_from_u32s; | ||
| use circuits_stark_verifier::proof_from_stark_proof::{pack_component_log_sizes, pack_enable_bits}; | ||
| use circuits_stark_verifier::proof_from_stark_proof::pack_enable_bits; |
There was a problem hiding this comment.
pack_component_log_sizes is now unused dead code
Low Severity
The pack_component_log_sizes function in proof_from_stark_proof.rs is now dead code. All call sites were removed in this PR (from circuit_claim.rs, simple_air.rs, and simple_air_test.rs), but the function definition was left behind. A grep confirms the only remaining match is the definition itself.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e4899a5. Configure here.



Component log sizes are fixed given the CircuitConfig, so derive them
from the preprocessed trace at proving time and route them through the
Cairo Statement's claims_to_mix rather than mixing them via
CircuitClaim::mix_into.