Skip to content

Add log_size fn to CircuitEval#490

Open
anatgstarkware wants to merge 1 commit intomainfrom
anatg/gen_log_size_fn
Open

Add log_size fn to CircuitEval#490
anatgstarkware wants to merge 1 commit intomainfrom
anatg/gen_log_size_fn

Conversation

@anatgstarkware
Copy link
Copy Markdown
Collaborator

No description provided.

@anatgstarkware anatgstarkware self-assigned this May 10, 2026
@cursor
Copy link
Copy Markdown

cursor Bot commented May 10, 2026

PR Summary

Medium Risk
Touches the core CircuitEval trait and updates many generated components to satisfy the new API; mistakes in per-component log_size values could lead to incorrect sizing assumptions downstream.

Overview
Adds a new required CircuitEval::log_size(...) -> Option<u32> hook, allowing components to report their effective log size based on preprocessed column sizes.

To support this, OrderedHashMap is moved/centralized into circuits-stark-verifier (with serde support), and circuit-common, cairo_verifier, circuit_verifier, and examples are updated to import it from the new location. All verifier components implement log_size (mostly None, with a few returning constants or looking up a specific PreProcessedColumnId).

Reviewed by Cursor Bugbot for commit ec7945c. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown
Collaborator

This change is Reviewable

@anatgstarkware anatgstarkware force-pushed the anatg/gen_log_size_fn branch 2 times, most recently from b9cbd4b to fddb2fc Compare May 10, 2026 19:12
Comment thread crates/stark_verifier/src/constraint_eval.rs
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 79d9c69. Configure here.

Comment thread crates/cairo_verifier/src/components/verify_bitwise_xor_12.rs
@anatgstarkware anatgstarkware force-pushed the anatg/gen_log_size_fn branch from 79d9c69 to ec7945c Compare May 10, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants