fix(keycard): Improve exception handling #19546
Open
+66
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
✔️ status-desktop/prs/android/arm64/package/PR-19546#1 🔹 ~9 min 51 sec 🔹 00978e3e 🔹 📦 android/arm64 package |
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19546#1 🔹 ~13 min 🔹 3eacf69 🔹 📦 tests/ui package |
Member
Member
Member
Member
✔️ status-desktop/e2e/prspr19546 🔹 ~14 min 🔹 3eacf69 🔹 📦 tests/e2e package |
Member
alexjba
force-pushed
the
fix/keycard-nfc-1
branch
from
3eacf69 to
1bb9a1e
Compare
Member
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19546#2 🔹 ~15 min 🔹 1bb9a1e 🔹 📦 tests/ui package |
Member
Member
Member
Member
alexjba
force-pushed
the
fix/keycard-nfc-1
branch
from
1bb9a1e to
e9d79a4
Compare
saledjenic
approved these changes
Dec 11, 2025
|
|
||
| method onUserAuthenticated*(self: Module, password: string, pin: string) = | ||
| if password.len == 0: | ||
| if password.len == 0 and pin.len == 0: |
Contributor
There was a problem hiding this comment.
A password should be set in both cases, regular/keycard user, while pin only for the keycard user, that's why only password was checked. It's not incorrect this way ofc.
| if keycardFlowType == ResponseTypeValueKeycardFlowResult: | ||
| if keycardEvent.error.len > 0: | ||
| if keycardEvent.error == ErrorOk: | ||
| if keycardEvent.error == ErrorOk or keycardEvent.error.len == 0: |
Contributor
There was a problem hiding this comment.
We're here only if the keycardEvent.error.len > 0 parent condition, so not needed toc check if keycardEvent.error.len == 0 here, cause will always be false. The same in 4 conditions below.
Contributor
Author
There was a problem hiding this comment.
removed these changes. Thanks!
- src/app/modules/main/wallet_section/send_new/module.nim Verify if both password and pin are empty before emitting the `authenticationCancelled` signal - handle card disconnect/reconnect when the user input is needed (enter pin, puk etc) - treat keycard message with empty error as successful - src/app_service/service/keycard/service.nim - avoid modifying the json container with itself. We're currently iterating the container and modifying the service member - leading to a freeze.
alexjba
force-pushed
the
fix/keycard-nfc-1
branch
from
e9d79a4 to
58d65b8
Compare
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19546#4 🔹 ~8 min 29 sec 🔹 58d65b8 🔹 📦 tests/nim package |
Member
Member
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19546#4 🔹 ~18 min 🔹 58d65b8 🔹 📦 tests/ui package |
Member
Member
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Iterates #19545
Preparing the nim code to work with
status-keycard-qt. Had a few cases where the current nim code had to be updated. Probably because thestatus-keycard-qtinternals are not identical tostatus-keycard-go.src/app/modules/main/wallet_section/send_new/module.nimVerify if both password and pin are empty before emitting theauthenticationCancelledsignalsrc/app/modules/shared_modules/keycard_popup/internal/insert_keycard_state.nim(and the other changes in states) handle card disconnect/reconnect when the user input is needed (enter pin, puk etc)src/app_service/service/keycard/service.nim- avoid modifying the json container with itself. We're currently iterating the container and modifying the service member - leading to a freeze.NOTE: Tests can be done in the final PR #19549