-
Notifications
You must be signed in to change notification settings - Fork 90
feat(Keycard): Adding a keycard info drawer for Android to guide the keycard interactions #19549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexjba
wants to merge
2
commits into
fix/keycard-nfc-3
Choose a base branch
from
fix/keycard-nfc-4
base: fix/keycard-nfc-3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,010
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19549#1 🔹 ~19 min 🔹 23b6c55 🔹 📦 tests/ui package |
Member
Member
Member
86711e0 to
e71a2fa
Compare
23b6c55 to
7515f6e
Compare
Member
Member
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19549#2 🔹 ~37 min 🔹 7515f6e 🔹 📦 tests/ui package |
Member
Member
Member
✔️ status-desktop/e2e/prspr19549 🔹 ~17 min 🔹 7515f6e 🔹 📦 tests/e2e package |
e71a2fa to
adabada
Compare
7515f6e to
0561ebc
Compare
adabada to
cd46a72
Compare
0561ebc to
ff70aed
Compare
Member
cd46a72 to
bcf9a24
Compare
…keycard interactions Adding a `KeycardChannelDrawer` that's guiding the user whenever the keycard is needed. On IOS the system drawer is used
ff70aed to
240efa3
Compare
saledjenic
approved these changes
Dec 11, 2025
Member
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19549#4 🔹 ~32 min 🔹 240efa3 🔹 📦 tests/nim package |
Member
Member
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19549#4 🔹 ~38 min 🔹 240efa3 🔹 📦 tests/ui package |
Member
Member
Member
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19549#5 🔹 ~44 min 🔹 b1b5809 🔹 📦 tests/nim package |
Member
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19549#5 🔹 ~50 min 🔹 b1b5809 🔹 📦 tests/ui package |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Iterating
#19545
#19546
#19547
#19548
Adding a
KeycardChannelDrawerthat's guiding the user whenever the keycard is needed.On IOS the system drawer is used.
Screencapture of the functionality
Screen_Recording_20251210_154214_Status.mp4
ScreenRecording_12-10-2025.17-21-13_1.MP4
Screen.Recording.2025-12-10.at.15.11.49.mov
Impact on end user
How to test
desktop:
make run USE_STATUS_KEYCARD_QT=1iOS:
make mobile-run USE_STATUS_KEYCARD_QT=1 DEVELOPMENT_TEAM=...android:
make mobile-run