feat_: add kv storage and handle rate limit state updates #6475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (58)
|
kaichaosun
force-pushed
the
feat/rln-store
branch
4 times, most recently
from
951fbf3 to
6ecf75e
Compare
kaichaosun
force-pushed
the
feat/rln-store
branch
from
6ecf75e to
ee7ed98
Compare
kaichaosun
force-pushed
the
feat/rln-store
branch
from
ee7ed98 to
a07aaec
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (48.71%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6475 +/- ##
===========================================
+ Coverage 60.65% 60.74% +0.09%
===========================================
Files 848 849 +1
Lines 105858 105935 +77
===========================================
+ Hits 64211 64355 +144
+ Misses 34006 33977 -29
+ Partials 7641 7603 -38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Apr 9, 2025
Contributor
Author
|
Close it for logos-messaging/pm#277 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rate limite states need to be persisted when updated, so the state is available after app restart.
A general kv store is best for this use case. Since status-go don't have KV storage yet and sqlite can be used for this purpose.
Important changes:
Closes #6401