Open
Conversation
4169749 to
1579041
Compare
07b7ff8 to
7f9fa2c
Compare
Author
|
@stevenlovegrove I wonder if you could have a look at this PR. It's a relatively small feature. |
Owner
|
Hi Erick - sorry I've never replied on this PR. I really like the idea and have actually been meaning to modify it slightly. My main objection to the current implementation is that it breaks the API. I have also been wanting to support colormaps and have been wondering if there is a unified API that could be used for the discrete and continuous use cases. |
…es the colour wheel
… breaking compatibility
ColorWheel interface.
9e64cab to
0e6bbfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an abstraction for color providers used by the plotter. ColourWheel becomes a provider, and it also adds a simple ColourCircularBuffer provider. The plotter constructor is overloaded to provide backwards compatibility, with the default being a ColourWheel provider (as before).
Same as before with the ColourWheel:

Using the simple ColourCircularBuffer (and shades of green):

The SimplePlot example is updated to showcase how this functionality works: