Skip to content

Test Workflow Improvements #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 20, 2025
Merged

Test Workflow Improvements #540

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f1c1af9
Update internal workflow
bpolania May 15, 2025
00d197e
Update pr-internal.yml
bpolania May 15, 2025
90e93bc
Pipeline fix for internal and external workflows
bpolania May 16, 2025
0d8af11
Update publish-package.yaml
bpolania May 16, 2025
b5e712d
Update publish-package.yaml
bpolania May 19, 2025
7bf06a5
Update publish-package.yaml
bpolania May 19, 2025
df270b3
Update package.json
bpolania May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pr-external.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
needs: [authorize]
uses: storyprotocol/gha-workflows/.github/workflows/reusable-timestamp.yml@main

pr_build_and_test:
unit_tests:
needs: [authorize, Timestamp_PR_APPROVED]
uses: storyprotocol/gha-workflows/.github/workflows/reusable-build-unit-test-workflow.yml@main
with:
Expand All @@ -32,11 +32,11 @@
WALLET_PRIVATE_KEY: ${{ secrets.WALLET_PRIVATE_KEY }}
TEST_WALLET_ADDRESS: ${{ secrets.TEST_WALLET_ADDRESS }}

push_build_and_test:
needs: [pr_build_and_test]
integration_tests:
needs: [unit_tests]
uses: storyprotocol/gha-workflows/.github/workflows/reusable-build-integration-test-workflow.yml@main
with:
sha: ${{ github.event.pull_request.head.sha }}
ENVIRONMENT: "odyssey"
secrets:
WALLET_PRIVATE_KEY: ${{ secrets.WALLET_PRIVATE_KEY }}
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/pr-internal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,22 @@
if: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
uses: storyprotocol/gha-workflows/.github/workflows/reusable-timestamp.yml@main

pr_build_and_test:
if: github.event_name == 'pull_request'
unit_tests:
needs: [Timestamp]
uses: storyprotocol/gha-workflows/.github/workflows/reusable-build-unit-test-workflow.yml@main
with:
sha: ${{ github.event.pull_request.head.sha }}
sha: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
ENVIRONMENT: "odyssey"
secrets:
WALLET_PRIVATE_KEY: ${{ secrets.WALLET_PRIVATE_KEY }}
TEST_WALLET_ADDRESS: ${{ secrets.TEST_WALLET_ADDRESS }}

push_build_and_test:
if: github.event_name == 'push'
integration_tests:
if: github.event_name == 'pull_request'
needs: [Timestamp]
uses: storyprotocol/gha-workflows/.github/workflows/reusable-build-integration-test-workflow.yml@main
with:
sha: ${{ github.sha }}
sha: ${{ github.event.pull_request.head.sha }}
ENVIRONMENT: "odyssey"
secrets:
WALLET_PRIVATE_KEY: ${{ secrets.WALLET_PRIVATE_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-package.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
npm publish
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

send_slack_notif-core-sdk:
needs: [print_version_to_publish]
uses: storyprotocol/gha-workflows/.github/workflows/reusable-slack-notifs.yml@main
Expand Down
2 changes: 1 addition & 1 deletion packages/core-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
],
"scripts": {
"build": "pnpm run fix && preconstruct build",
"test": "pnpm run test:unit",
"test": "pnpm run test:unit && pnpm run test:integration",
"test:unit": "TS_NODE_PROJECT='./tsconfig.test.json' c8 --all --src ./src mocha -r ts-node/register './test/unit/**/*.test.ts'",
"test:integration": "TS_NODE_PROJECT='./tsconfig.test.json' mocha -r ts-node/register './test/integration/**/*.test.ts' --timeout 300000",
"fix": "pnpm run format:fix && pnpm run lint:fix",
Expand Down
Loading