Skip to content

Test Workflow Improvements #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 20, 2025
Merged

Test Workflow Improvements #540

merged 7 commits into from
May 20, 2025
+22 −20

Conversation

bpolania
Copy link
Collaborator

@bpolania bpolania commented May 15, 2025 •
edited
Loading

Description

This PR fixes the current unit/integration tests workflow.

  • Sets integration tests only after a PR is submitted.
  • Sets unit tests only after a push.
  • Fixes the issues with the notification to 57Blocks slack channel

bonnie57
bonnie57 reviewed May 16, 2025
View reviewed changes
Copy link
Collaborator

@bonnie57 bonnie57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to trigger pr-internal and pr-external when a pull request is created.
Then we need to run unit tests and integration tests when pr code changes.

bonnie57
bonnie57 approved these changes May 20, 2025
View reviewed changes
Copy link
Collaborator

@bonnie57 bonnie57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AndyBoWu
AndyBoWu approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@AndyBoWu AndyBoWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpolania bpolania merged commit 292f7c4 into main May 20, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyBoWu AndyBoWu AndyBoWu approved these changes

@bonnie57 bonnie57 bonnie57 approved these changes

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

@DonFungible DonFungible Awaiting requested review from DonFungible DonFungible is a code owner

@edisonz0718 edisonz0718 Awaiting requested review from edisonz0718 edisonz0718 is a code owner

@jacob-tucker jacob-tucker Awaiting requested review from jacob-tucker jacob-tucker is a code owner

@allenchuang allenchuang Awaiting requested review from allenchuang allenchuang is a code owner

@DracoLi DracoLi Awaiting requested review from DracoLi DracoLi is a code owner

@limengformal limengformal Awaiting requested review from limengformal limengformal is a code owner

@lucas2brh lucas2brh Awaiting requested review from lucas2brh lucas2brh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpolania @AndyBoWu @bonnie57