Add Link warmup pane for deferred intents #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/ibp-consumer-lookup
branch
from
a11abfb to
eee66d1
Compare
tillh-stripe
force-pushed
the
tillh/ibp-consumer-lookup
branch
2 times, most recently
from
174c526 to
45baf7b
Compare
mats-stripe
reviewed
Mar 4, 2025
...inancialConnections/StripeFinancialConnections/Source/Native/Consent/ConsentDataSource.swift
Show resolved
Hide resolved
...inancialConnections/StripeFinancialConnections/Source/Native/Consent/ConsentDataSource.swift
Outdated
Show resolved
Hide resolved
StripeFinancialConnections/StripeFinancialConnections/Source/Native/NativeFlowController.swift
Outdated
Show resolved
Hide resolved
tillh-stripe
force-pushed
the
tillh/ibp-consumer-lookup
branch
from
45baf7b to
173fbb1
Compare
tillh-stripe
changed the base branch from
master
to
tillh/earlier-consumer-session-lookup
tillh-stripe
commented
Mar 5, 2025
Comment on lines
124
to
130
| if dataSource.hasConsumerSession { | ||
| // We already have a consumer session, so let's us this one directly | ||
| delegate?.networkingLinkLoginWarmupViewControllerDidSelectContinue(self) | ||
| return | ||
| } |
There was a problem hiding this comment.
Avoiding multiple consumer session creations.
tillh-stripe
commented
Mar 5, 2025
| @@ -14,8 +14,11 @@ typealias NetworkingLinkLoginWarmupFooterView = (footerView: UIView?, primaryBut | |||
|
|
|||
| protocol NetworkingLinkLoginWarmupViewControllerDelegate: AnyObject { | |||
| func networkingLinkLoginWarmupViewControllerDidSelectContinue( | |||
| _ viewController: NetworkingLinkLoginWarmupViewController | |||
| ) | |||
| func networkingLinkLoginWarmupViewControllerDidFindConsumerSession( | |||
There was a problem hiding this comment.
Split this out of the didSelectContinue method, so we can more easily call it if we already have a consumer session.
tillh-stripe
force-pushed
the
tillh/ibp-consumer-lookup
branch
2 times, most recently
from
da28621 to
7d0177a
Compare
tillh-stripe
force-pushed
the
tillh/earlier-consumer-session-lookup
branch
from
2454838 to
594dea6
Compare
tillh-stripe
force-pushed
the
tillh/ibp-consumer-lookup
branch
from
7d0177a to
ea75d91
Compare
mats-stripe
previously approved these changes
Mar 6, 2025
| struct ConsentAcquiredResult { | ||
| var manifest: FinancialConnectionsSessionManifest | ||
| var consumerSession: ConsumerSessionData? = nil | ||
| var publishableKey: String? = nil |
There was a problem hiding this comment.
Assuming this is the consumer session publishable key, should we name this property something like consumerPublishableKey?
| ) | ||
| promise.resolve(with: result) | ||
| case .failure: | ||
| let result = ConsentAcquiredResult(manifest: manifest) |
There was a problem hiding this comment.
Just to confirm, we're ok failing silently here?
There was a problem hiding this comment.
Yes. It just means that looking up the session failed, so we’d navigate to the manifest’s nextPane.
If that’s linkLogin (like it is for IBP today), the user would be recognized after their email is prefilled (basically today‘s experience).
tillh-stripe
added a commit
that referenced
this pull request
Mar 6, 2025
## Summary <!-- Simple summary of what was changed. --> This pull request aligns the Financial Connections iOS SDK with Android and Web, where we create a consumer session before we display any verification screens. This removes a decent amount of error handling code (for very unlikely errors) and will make implementing #4272 correctly easier. ## Motivation <!-- Why are you making this change? If it's for fixing a bug, if possible, please include a code snippet or example project that demonstrates the issue. --> ## Testing <!-- How was the code tested? Be as specific as possible. --> ## Changelog <!-- Is this a notable change that affects users? If so, add a line to `CHANGELOG.md` and prefix the line with one of the following: - [Added] for new features. - [Changed] for changes in existing functionality. - [Deprecated] for soon-to-be removed features. - [Removed] for now removed features. - [Fixed] for any bug fixes. - [Security] in case of vulnerabilities. --> --------- Co-authored-by: Mat Schmid <[email protected]>
tillh-stripe
force-pushed
the
tillh/ibp-consumer-lookup
branch
from
ea75d91 to
89675e4
Compare
mats-stripe
previously approved these changes
Mar 6, 2025
...inancialConnections/StripeFinancialConnections/Source/Native/Consent/ConsentDataSource.swift
Show resolved
Hide resolved
Rename `publishableKey` to `consumerPublishableKey`.
tillh-stripe
force-pushed
the
tillh/ibp-consumer-lookup
branch
from
89675e4 to
efe99c7
Compare
tillh-stripe
force-pushed
the
tillh/ibp-consumer-lookup
branch
from
efe99c7 to
63c1fde
Compare
mats-stripe
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the returning-user experience for IBP consumers when the flow is opened for deferred intents. With those, we don’t have a populated
accountholderCustomerEmailAddress, so we need to manually look for a consumer account after the user accepts on the consent pane.It also updates the warmup pane to only lookup a consumer session if there isn’t one yet.
Motivation
Testing
Changelog