Ensure that previous_attributes is always an instance of StripeObject#2011
Open
simonhammes wants to merge 1 commit intostripe:masterfrom
Open
Ensure that previous_attributes is always an instance of StripeObject#2011simonhammes wants to merge 1 commit intostripe:masterfrom
previous_attributes is always an instance of StripeObject#2011simonhammes wants to merge 1 commit intostripe:masterfrom
Conversation
simonhammes
requested review from
prathmesh-stripe
and removed request for
a team
|
|
simonhammes
force-pushed
the
ensure-previous_attributes-is-stripe-object
branch
from
07a68e9 to
fd0a48f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1785
Why?
The
@propertyannotation on theEventclass says thatprevious_attributesis always an instance ofStripeObject(or null).#1785 shows that this is currently not guaranteed since an empty array is deserialized into an empty PHP array instead of a
StripeObjectobject.What?
This PR adds a second special case to the deserialization logic inside
StripeObject.Previously, the
metadataproperty was special-cased to guarantee the same behavior.