Skip to content

Ensure that previous_attributes is always an instance of StripeObject #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonhammes wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −1
Open

Ensure that previous_attributes is always an instance of StripeObject #2011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/StripeObject.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,8 @@ public function updateAttributes($values, $opts = null, $dirty = true, $apiMode
// This is necessary in case metadata is empty, as PHP arrays do
// not differentiate between lists and hashes, and we consider
// empty arrays to be lists.
if (('metadata' === $k) && \is_array($v)) {
// The same applies to the previous_attributes attribute.
if (('metadata' === $k || 'previous_attributes' === $k) && \is_array($v)) {
$this->_values[$k] = StripeObject::constructFrom($v, $opts, $apiMode);
} else {
$this->_values[$k] = Util\Util::convertToStripeObject($v, $opts, $apiMode);
Expand Down
12 changes: 12 additions & 0 deletions tests/Stripe/StripeObjectTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,4 +597,16 @@ public function testDeserializeMetadataWithKeyNamedMetadata()
$inner = $obj->metadata;
self::assertSame('value', $inner->metadata);
}

public function testDeserializeEmptyPreviousAttributes()
{
/** @var mixed $obj */
$obj = StripeObject::constructFrom([
'data' => [
'previous_attributes' => [],
],
]);

self::assertInstanceOf(StripeObject::class, $obj->data->previous_attributes);
}
}