Bump required VSCode version to 1.82.3 #503
Conversation
VSCode 1.86.1 included the Electron 27 update. This comes with Node.js 18.17.1. Ref https://code.visualstudio.com/updates/v1_86 Also, this change removes the Node.js version from the CI testing matrix, following the `engines.node` field in `package.json`.
| const pkg = require('../../package.json'); | ||
|
|
||
| const vscodeVersion = '1.86.1'; | ||
| const requiredVscodeVersion = pkg.engines.vscode.match(/\d+\.\d+\.\d+/)?.[0]; |
There was a problem hiding this comment.
[note] This file is used as a cache key on CI. So, we must update this file when bumping the VSCode version.
This reverts commit 83ebf25.
ybiquitous
changed the title
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "stylelint.customSyntax": "${workspaceFolder}/custom-syntax.js", | |||
| "editor.codeActionsOnSave": { | |||
| "source.fixAll.stylelint": true | |||
| "source.fixAll.stylelint": "explicit" | |||
@adalinesimonian Any thoughts on the comment above? |
Yes, it's an nvm alternative that I and other folks use. |
|
Okay. We have to update the Volta settings, right? E.g. "volta": {
- "node": "14.17.6",
+ "node": "18.15.0",
"npm": "8.1.3"
}Also, do we need |
Yes, correct.
It's a good practice to pin the npm version as well so that no one runs into weird package manager quirks, same with how we pin our dependencies. 9 is fine. |
|
Thanks. I just updated the Volta settings via 1c1c86f. |
Closes #435
VSCode 1.82.3 included the Electron 25 update. This comes with Node.js 18.15.0.
Ref https://code.visualstudio.com/updates/v1_82
Also, this change removes the Node.js version from the CI testing matrix, following the
engines.nodefield inpackage.json.Just to be sure, is Volta still used? If unused, I'd like to remove the settings to achieve DRY.
vscode-stylelint/package.json
Lines 282 to 285 in 2b59af3