This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Refactor background jobs #996
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
bfollington
force-pushed
the
2023-11-13-background-jobs
branch
from
d37f015 to
a23615c
Compare
bfollington
added a commit
that referenced
this pull request
Nov 14, 2023
…#990) Improves #989 Fixes #946 Fixes #977 This PR remodels the follow/unfollow/rename operations and refresh lifecycle. It also introduces support for indexing multiple peers that point to the same DID. https://github.com/subconsciousnetwork/subconscious/assets/5009316/58541708-99e1-4975-b2c1-97f079c0c66b I intend to refactor the "wait for petname resolution" logic and background jobs in general as a follow up in #996 # Tasks - [x] Fix edgecase with alias rendering - [x] Index peers by petname rather than DID - [x] Move all follow/unfollow/rename communication to app root - [x] Allow refreshing profile while displaying existing loaded content - [x] Allow omnibar animation to start and stop multiple times - [x] Refresh profile immediately after follow / unfollow - [x] Kick off resolution immediately after rename - [x] Kick off re-index immediately after follow / unfollow / resolve / rename - [x] Trigger toast notifications for follow / unfollow / rename
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #658
Fixes #938
TODO
AppModel