Fix NavigationSplitView overflow at small window with a wide sidebar#154
Closed
rexbron wants to merge 1 commit into
Closed
Fix NavigationSplitView overflow at small window with a wide sidebar#154rexbron wants to merge 1 commit into
rexbron wants to merge 1 commit into
Conversation
At the minimum window width, dragging the room-list sidebar wide pushed the split-view content past the window: the sidebar shoved off the left edge and the detail pane spilled past the right, clipping content (the timeline appeared to clip its rows). The window minimum (700) was smaller than rail (52) + sidebar max (360) + a usable timeline, so NavigationSplitView overflowed instead of compressing the user-dragged sidebar. Confirmed on main; shrinking the room list manually relieved it. Restore the invariant window.min >= rail + sidebar.max + timeline.min with a balanced adjustment: - Sidebar max 360 -> 300 (ideal 300 -> 280). - Window min 700 -> 752 (height 500 -> 480), which keeps the worst case fitting (52 + 300 + 400 = 752). The 752x480 minimum is also chosen to fit a quarter-screen tile on a 14" MacBook Pro at its default scaled resolution (1512x982 pt, quarter ~756x491) with a few points of margin for macOS tiling gaps, so the window snaps cleanly into a 2x2 grid. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
|
I think I fixed this in c808bd1...007fba4 |
Contributor
Author
I just built main [ffb1ee8] and I agree, the overflow to the left is fixed. That said, we seem to have lost the compact view for the room list. Screen.Recording.2026-06-27.at.09.12.32_quash.mp4 |
Owner
|
Oh, that might be a miscalculation because you don't have any spaces. I'll test that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the minimum window width, dragging the room-list sidebar wide pushed the split-view content past the window — the sidebar shoved off the left edge and the detail pane spilled past the right, clipping content (the timeline looked like it was clipping its rows).
Cause
The window minimum (700pt) was smaller than
rail (52) + sidebar max (360) + a usable timeline. When the user-dragged sidebar plus the detail's content couldn't both fit,NavigationSplitViewoverflowed the window instead of compressing the (sticky) sidebar. Logging confirmed the detail pane's frame growing past the visible window width while the sidebar was pushed to a negative x. The row heights themselves were always measured correctly — the apparent "row clipping" was content spilling past the window edge.Fix
Restore the invariant
window.min ≥ rail + sidebar.max + timeline.min, balanced across both levers so neither changes much:52 + 300 + 400 = 752.The 752×480 minimum also fits a quarter-screen tile on a 14″ MacBook Pro at its default scaled resolution (1512×982 pt → quarter ≈ 756×491), with a few points of margin for macOS tiling gaps, so the window snaps cleanly into a 2×2 grid.
Testing