Skip to content

Fix NavigationSplitView overflow at small window with a wide sidebar #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rexbron wants to merge 1 commit into from
Closed

Fix NavigationSplitView overflow at small window with a wide sidebar #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Relay/ContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,12 @@ struct ContentView: View {
}
}
.relayErrorAlert()
.frame(minWidth: 700, minHeight: 500)
// Sized to fit a quarter-screen tile on a 14" MacBook Pro at its
// default scaled resolution (1512×982 pt → quarter ≈ 756×491), with a
// few points of margin for macOS tiling gaps. The width must also clear
// the sidebar overflow invariant: rail 52 + sidebar max 300 + a usable
// timeline (400) = 752.
.frame(minWidth: 752, minHeight: 480)
}
}

Expand Down
7 changes: 6 additions & 1 deletion Relay/Views/MainView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,12 @@ struct MainView: View { // swiftlint:disable:this type_body_length
spaceRailView
}
}
.navigationSplitViewColumnWidth(min: 160, ideal: 300, max: 360)
// Keep the sidebar narrow enough that, even at its max, it plus the
// 52pt space rail and a usable timeline fit inside the 760pt minimum
// window — otherwise NavigationSplitView overflows the window (the
// sidebar shoves off the left edge and the detail spills past the
// right) instead of compressing the user-dragged sidebar.
.navigationSplitViewColumnWidth(min: 160, ideal: 280, max: 300)
}

// MARK: - Detail
Expand Down
Loading