fix: correct misleading proof verification warning on macOS #2299
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very interesting that this issue occurred only on macOS, but Ubuntu is fine if the glitch is OS-unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Issue #2289 reports a potentially misleading warning "Not all proofs were read" on macOS (Apple Silicon) that doesn't appear on Ubuntu.
Solution
Fixed the issue by only incrementing the proof_stream_ptr counter when verification actually occurs.
Previously, the counter was always incremented regardless of whether verification happened, causing a mismatch between the number of processed proofs and the counter value.
PR Checklist