Skip to content

fix: correct misleading proof verification warning on macOS #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: correct misleading proof verification warning on macOS #2299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions crates/core/executor/src/syscalls/verify.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ impl Syscall for VerifySyscall {
panic!("Not enough proofs were written to the runtime.");
}
let (proof, proof_vk) = &rt.state.proof_stream[proof_index].clone();
rt.state.proof_stream_ptr += 1;


let vkey_bytes: [u32; 8] = vkey.try_into().unwrap();
let pv_digest_bytes: [u32; 8] = pv_digest.try_into().unwrap();
if let Some(verifier) = rt.subproof_verifier {
Expand All @@ -45,7 +44,10 @@ impl Syscall for VerifySyscall {
e
)
});
} else if rt.state.proof_stream_ptr == 1 {
// Only increment the proof stream pointer if verification actually happened
rt.state.proof_stream_ptr += 1;
} else {
// Only log but don't increment proof_stream_ptr when not verifying
tracing::info!("Not verifying sub proof during runtime");
}
}
Expand Down