fix(recursion): set is_sub_builder flag in new_sub_builder #2529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
is_sub_builderflag was never being set totruewhen creating sub-builders vianew_sub_builder(). This meant all the assert guards inwitness_var(),witness_felt(),witness_ext(), andcommit_public_value()were effectively dead code - they could never trigger.This is problematic because
witness_*functions use local counters (witness_var_count, etc.) that start at 0 in each sub-builder,creating index conflicts if called from within loops or conditionals.
Solution
is_sub_builder = trueinnew_sub_builder()so the protection actually workscommit_public_value()since it's safely called from sub-builders insidecommit_public_values()(thenb_public_valuesvariable is properly shared between builders)PR Checklist