Skip to content

fix(recursion): set is_sub_builder flag in new_sub_builder #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MozirDmitriy wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(recursion): set is_sub_builder flag in new_sub_builder #2529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/recursion/compiler/src/ir/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ impl<C: Config> Builder<C> {
builder.nb_public_values = nb_public_values;
builder.p2_hash_num = p2_hash_num;
builder.debug = debug;
builder.is_sub_builder = true;

builder
}
Expand Down Expand Up @@ -431,7 +432,6 @@ impl<C: Config> Builder<C> {

/// Register and commits a felt as public value. This value will be constrained when verified.
pub fn commit_public_value(&mut self, val: Felt<C::F>) {
assert!(!self.is_sub_builder, "Cannot commit to a public value with a sub builder");
if self.nb_public_values.is_none() {
self.nb_public_values = Some(self.eval(C::N::zero()));
}
Expand Down
Loading