Fix ReferenceError: docById is not defined in activity.js#4293
Closed
Sarvesh2783 wants to merge 1 commit intosugarlabs:masterfrom
Closed
Fix ReferenceError: docById is not defined in activity.js#4293Sarvesh2783 wants to merge 1 commit intosugarlabs:masterfrom
Sarvesh2783 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Member
|
Isn't this defined in utils.js? Why do we need to define it twice? |
Contributor
|
all we have to do was to comment out the console.log(error) in this one. |
Closed
Contributor
Author
|
@walterbender Thank you for pointing this out! I missed that the docById function was already defined elsewhere. I'll update the PR to reuse the existing function instead of redefining it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4292 -ReferenceError: docById is not defined in activity.js during initialization
This PR resolves the ReferenceError: docById is not defined in activity.js by replacing the undefined docById function with document.getElementById.
Steps to Reproduce the Error:
Root Cause:
The docById function is not defined in the codebase, leading to this error.
Proposed Solution:
Replaced all occurrences of docById with document.getElementById to ensure proper functionality.
Additional Details