Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Play-Only-Mode to MusicBlocks #4320

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justin212407
Copy link
Contributor

I have made some changes regarding the play-only-mode features, basically now the palette goes away whenever the play-only-mode is triggered. This mode is triggered automatically when the screen size goes below 768px in width or 600px in height. These are the basic changes i have made till now. I'll be adding more features to this to make this a better working feature in the upcoming days after taking inputs on what should be added. For now it looks something like this.

Untitled.video.-.Made.with.Clipchamp.1.mp4

@walterbender @pikurasa I am still not sure on what features should be added to the dropdown menu. Please take a look at this till now and suggest if this looks good.

@walterbender
Copy link
Member

@pikurasa What do you think? Maybe we want a message explaining that we are in playback only mode and that to enjoy the whole MB experience, you need a larger display?

@pikurasa
Copy link
Collaborator

@pikurasa What do you think? Maybe we want a message explaining that we are in playback only mode and that to enjoy the whole MB experience, you need a larger display?

I agree.

Would this be the usual method, or a more persistent message?

Also, do we want all of the buttons at the bottom-right of the screen? Home could be helpful. Perhaps expand and collapse could be helpful. I doubt zoom in and zoom out will be helpful.

We may consider:

  • A persistent message at the bottom that says "Play only mode. For the full Music Blocks experience, please open with a larger display."
  • Only the home button at the bottom-right corner

Thoughts?

@justin212407
Copy link
Contributor Author

@pikurasa sure that would make sure that the user gets the best of the experience that MusicBlocks can provide and about the expand and collapse i don't think it makes much of a sense to add that for a playback mode feature since its mostly just related to listening how the music works.

@justin212407
Copy link
Contributor Author

@walterbender @pikurasa Other than this for the dropwdown menu that we talked about you know of changing auxiliary menu with the dropdown one, i guess we can use the same element that has been used for the select language toggle, this would ensure uniformity across the codebase. What are your thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants