Dynamically changing the theme in realtime #4339
Closed
omsuneri wants to merge 1 commit intosugarlabs:masterfrom
Closed
Dynamically changing the theme in realtime #4339omsuneri wants to merge 1 commit intosugarlabs:masterfrom
omsuneri wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Member
Author
|
@walterbender i ll be making this feature works very soon as of now only the toolbar changes the theme and I m working on the other UI elements to change the theme too. |
Member
Author
|
closing this as not a priority currently |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently the user needs to refresh the browser page to get the dark mode applied
after these changes the user can switch between the themes in realtime without refreshing the browser page
and this is how it creates a better user experience.