Closed
Conversation
Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>
Member
Author
|
@walterbender please review this |
Member
Member
Author
|
Ohh i guess it got overlooked i'll fix that and push that commit too |
Member
|
The grids are rendered with this method: https://github.com/sugarlabs/musicblocks/blob/master/js/activity.js#L2438 But the individual grid SVGs are defined in artwork.js |
Member
Author
|
Sure i will take a look into it and make all the neccessary changes and then update this pr |
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description:
This PR addresses issue #4429 and fixes UI issues in dark mode affecting the grid, dialog box, and dropdown.
Changes Made:
Fixed grid and dialog box styling to ensure proper visibility in dark mode.
Adjusted background and text colors to match the dark theme.
Screenshots:
Checklist: