Adding Meta tag for ensuring transition of Play-Only-Mode#4494
Adding Meta tag for ensuring transition of Play-Only-Mode#4494walterbender merged 2 commits intosugarlabs:masterfrom
Conversation
Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender Please review this This PR adds a meta tag that tells mobile browsers to use the actual device width as the layout port so that the play only mode does not face an issue while rendering it on the user's phone screen |
…into play-only-mode-bug
|
✅ All Jest tests passed! This PR is ready to merge. |
|
So what i figured out is that this is not an actual bug in our code or our meta tag. On a real mobile device or when we physically shrink the desktop browser below 768 pixel, play-only mode works exactly as intended. The issue stems from how DevTools emulates different devices and scales as it can still report a larger width due to custom zoom and high device-pixel ratios in ‘Responsive’ mode. The meta viewport is crucial for correct rendering on real mobile devices otherwise, it might appear zoomed out or have incorrect breakpoints. On a real phone, that meta viewport ensures window.innerWidth matches the phone’s actual CSS width. |
|
@walterbender should i try to fix that record button scaling issue in this PR ? |
|
Let's look at Record in a separate PR |
Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>
|
Sure I'll definitely do that |
Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>

This is a draft PR regarding fixing the issue of the play-only-mode not rendering even when the trigger point is reached. This PR is related to fixing #4493.