Skip to content

Adding Meta tag for ensuring transition of Play-Only-Mode#4494

Merged
walterbender merged 2 commits intosugarlabs:masterfrom
justin212407:play-only-mode-bug
Mar 10, 2025
Merged

Adding Meta tag for ensuring transition of Play-Only-Mode#4494
walterbender merged 2 commits intosugarlabs:masterfrom
justin212407:play-only-mode-bug

Conversation

@justin212407
Copy link
Copy Markdown
Member

@justin212407 justin212407 commented Mar 4, 2025

This is a draft PR regarding fixing the issue of the play-only-mode not rendering even when the trigger point is reached. This PR is related to fixing #4493.

Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 4, 2025

✅ All Jest tests passed! This PR is ready to merge.

@justin212407 justin212407 changed the title Fixing no rendering of Play-Only-Mode Adding Meta tag for ensuring transition of Play-Only-Mode Mar 9, 2025
@justin212407 justin212407 marked this pull request as ready for review March 9, 2025 12:12
@justin212407
Copy link
Copy Markdown
Member Author

@walterbender Please review this This PR adds a meta tag that tells mobile browsers to use the actual device width as the layout port so that the play only mode does not face an issue while rendering it on the user's phone screen

@walterbender
Copy link
Copy Markdown
Member

Not 100% sure I understand what this does, but it doesn't seem to break anything.

FYI, I did notice this one anomaly, unrelated to this PR, but related to the general theme.

Screenshot From 2025-03-09 18-06-47

Notice that the record button doesn't scale with the other icons.

@github-actions
Copy link
Copy Markdown
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@justin212407
Copy link
Copy Markdown
Member Author

So what i figured out is that this is not an actual bug in our code or our meta tag. On a real mobile device or when we physically shrink the desktop browser below 768 pixel, play-only mode works exactly as intended. The issue stems from how DevTools emulates different devices and scales as it can still report a larger width due to custom zoom and high device-pixel ratios in ‘Responsive’ mode. The meta viewport is crucial for correct rendering on real mobile devices otherwise, it might appear zoomed out or have incorrect breakpoints. On a real phone, that meta viewport ensures window.innerWidth matches the phone’s actual CSS width.

@justin212407
Copy link
Copy Markdown
Member Author

@walterbender should i try to fix that record button scaling issue in this PR ?

@walterbender walterbender merged commit f89fedb into sugarlabs:master Mar 10, 2025
5 checks passed
@walterbender
Copy link
Copy Markdown
Member

Let's look at Record in a separate PR

Ubayed-Bin-Sufian pushed a commit to Ubayed-Bin-Sufian/musicblocks that referenced this pull request Mar 10, 2025
Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>
@justin212407
Copy link
Copy Markdown
Member Author

Sure I'll definitely do that

sa-fw-an pushed a commit to sa-fw-an/musicblocks that referenced this pull request Apr 29, 2025
Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants