fix calculation of the height and width as per viewport (for play-only-mode)#4495
Closed
apsinghdev wants to merge 1 commit intosugarlabs:masterfrom
Closed
fix calculation of the height and width as per viewport (for play-only-mode)#4495apsinghdev wants to merge 1 commit intosugarlabs:masterfrom
apsinghdev wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
The question is, at what point do we want to transition. It looks to me like the emulated iPhone image you are sharing has sufficient resolution to work with, although not necessarily a pleasant experience. |
Member
|
The transition point i kept in my PR initially was of a screen width of 759px. Also i have tried using the meta tag in my draft PR itself for the same and this approach does not exactly work. |
Contributor
|
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
Contributor
|
Closed pull request due to inactivity for more than 63 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #4493
I believe this is more of a DPR issue because modern devices (like the iPhone XR) have high-resolution screens. The iPhone XR, for example, has a DPR of 2. This means:
The actual screen resolution is 828 x 1792 pixels (logical resolution × DPR).
The logical resolution (CSS pixels) is 414 x 896 pixels.
The issue is the environment we are testing in. If you check the same code on an actual phone or device with a defined height and width, this issue will not arise. Browsers can simulate the width and height of the phone screens but don't match their respective DPR.
@walterbender Please take a look.