Adding new frame drum - duff by sa-fw-an · Pull Request #4496 · sugarlabs/musicblocks

sa-fw-an · 2025-03-05T13:57:45Z

Description

Updated the Drum list by adding a new type of frame drum called as duff. Users can now enjoy this new functionality :)

Users can access duff as shown in the video below:

Screen.Recording.2025-03-05.at.7.23.43.PM.mov

github-actions · 2025-03-05T13:58:30Z

✅ All Jest tests passed! This PR is ready to merge.

sa-fw-an · 2025-03-05T13:58:30Z

@pikurasa , @walterbender Please review this PR :)

walterbender · 2025-03-05T15:31:49Z

Should this be a Daf instead of a Duff? What is the more common spelling/pronunciation?

sa-fw-an · 2025-03-05T16:59:40Z

I named it as Duff bcz the sample that ive put is an Indian sample and also in India it is called as Duff.
Refered from wiki
But still Duff is originally from Middle East (they call it Daf) so it might sound reasonable to name it Daf.

What would u suggest?

walterbender · 2025-03-05T17:13:42Z

I am not sure. I suppose Duff is fine. @pikurasa any suggestions?

pikurasa · 2025-03-05T18:35:49Z

As for the sound itself, it sounds pretty good. However, it sounds like it gets cut off prematuraly. I tested the branch locally with longer note lengths, and this seems to be true regardless of the length.

@sa-fw-an I assume the sample you used is longer than what you uploaded here. Perhaps you can redo this PR (rebase or otherwise) with the full length of the drum sound?

If you have any questions about the sample, you could upload it into a comment and I can listen before doing anything to this PR.

pikurasa · 2025-03-05T18:36:49Z

As for "Duff" vs. "Daff", we could perhaps use different terminology based on the language.

I don't know that much about these drums, so I'd need to ask someone else about it for a more informed response.

sa-fw-an · 2025-03-07T18:24:58Z

As for the sound itself, it sounds pretty good. However, it sounds like it gets cut off prematuraly. I tested the branch locally with longer note lengths, and this seems to be true regardless of the length.

@sa-fw-an I assume the sample you used is longer than what you uploaded here. Perhaps you can redo this PR (rebase or otherwise) with the full length of the drum sound?

If you have any questions about the sample, you could upload it into a comment and I can listen before doing anything to this PR.

Yea i had to edit the audio file a bit to remove the extra sound. Unfortunately github does not allow audio files to be uploaded in comments. Will share the audio directly with you

haroon10725 · 2025-03-08T00:44:14Z

As for the sound itself, it sounds pretty good. However, it sounds like it gets cut off prematuraly. I tested the branch locally with longer note lengths, and this seems to be true regardless of the length.

@sa-fw-an I assume the sample you used is longer than what you uploaded here. Perhaps you can redo this PR (rebase or otherwise) with the full length of the drum sound?

If you have any questions about the sample, you could upload it into a comment and I can listen before doing anything to this PR.

Yea i had to edit the audio file a bit to remove the extra sound. Unfortunately github does not allow audio files to be uploaded in comments. Will share the audio directly with you

@sa-fw-an You can convert it into mp4 format and then share it.

pikurasa · 2025-03-10T14:54:43Z

Yea i had to edit the audio file a bit to remove the extra sound. Unfortunately github does not allow audio files to be uploaded in comments. Will share the audio directly with you

You can zip the file and upload it.

sa-fw-an · 2025-03-11T04:30:13Z

Here is the File which contains both the full and edited audio:

Duff.zip

walterbender · 2025-03-22T14:06:23Z

@pikurasa if you approve, I can add the Duff.

walterbender · 2025-04-23T22:02:49Z

@pikurasa OK to merge?

pikurasa · 2025-04-24T21:01:24Z

There is still a clipping of the sound at the end of the file. @sa-fw-an needs to find a point in the sound to cut it where it avoids such clipping.

sa-fw-an · 2025-04-25T12:40:08Z

There is still a clipping of the sound at the end of the file. @sa-fw-an needs to find a point in the sound to cut it where it avoids such clipping.

Will work soon on this

* Add license headers to JavaScript files * Fixing author name

…vation (sugarlabs#4476) * fix localization strings for motion-y and get-protein in Arabic * Refactor text cleaning and translation retrieval in utils.js * Fix comment formatting in getTranslationWithCase function

…garlabs#4498) Co-authored-by: Studycode001 <148090007+Studycode001@users.noreply.github.com>

* test suite for lilypond.js * license

Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>

…o correct source

* Adding test cases for BooleanBlocks.js * Exporting modules for test

* Adding urdu translation in localization.ini * Adding urdu translation in ur.po

* Add frequency display to Sampler Widget * Fix pitch button * Use platformColor.textColor instead of hardcoded color --------- Co-authored-by: Anvita Prasad <cs23b1059.iiitdm.ac.in>

* TimbreUI * linting * unused elements

Co-authored-by: Anvita Prasad <cs23b1059.iiitdm.ac.in>

…4622) * Add documentation for frequency display in Sampler widget * Update documentation to use A notes as examples --------- Co-authored-by: Anvita Prasad <cs23b1059.iiitdm.ac.in>

* edited * added tests for toneBlocks.js * fixed linting issues --------- Co-authored-by: Studycode001 <148090007+Studycode001@users.noreply.github.com>

* bug fixes * coment * singer fix * max value 1000 for base frequency

Co-authored-by: Anvita Prasad <cs23b1059.iiitdm.ac.in>

…4629) * Enhance browser action tests for Firefox and Chrome environments * Improve test coverage for languagebox.js Signed-off-by: asim <aktech701@gmail.com> --------- Signed-off-by: asim <aktech701@gmail.com>

* fix(pastebox.test.js): Improved test coverage by 28% * fix(trash.test.js): Improved test coverage by 32% * fix(trash.test.js): Improved test coverage by 32% * fix(planetInterface.test.js): Improved test coverage by 65.5% * fix(planetInterface.test.js): Improved test coverage by 65.5%

* improved test coverage for js/turtleactions/dictactions.js * improved test coverage for js/turtleactions/dictactions.js

* added tests for meteractions.js * added tests for meteractions.js

* added coverage for pitchactions.js * added coverage for pitchactions.js * added coverage for pitchactions.js * bumped test coverage for pitchactions.js * bumped test coverage for pitchactions.js

…4645) * Improved accessibility: added alt and title to logo image * fix: removed title attribute from amp-img

* play chord * semicolon added

* rafactor from html4 to html5 * fixed wheelDiv's visibility * fixed the auxillary menu problem

github-actions · 2025-04-29T03:04:02Z

✅ All Jest tests passed! This PR is ready to merge.

sa-fw-an · 2025-04-29T03:05:49Z

Ah my bad will open a new PR 🥲

sa-fw-an · 2025-04-29T03:26:59Z

New PR Adding new frame drum - duff #4663

Adding new frame drum - duff

d757421

Ubayed-Bin-Sufian and others added 14 commits April 29, 2025 08:33

update MB v4 link (sugarlabs#4501)

293185b

Add AGPL-3.0 License Headers to Missing Files (sugarlabs#4488)

d6fb4f6

* Add license headers to JavaScript files * Fixing author name

Implement draggable divider for resizing editor and console areas (su…

96287bb

…garlabs#4498) Co-authored-by: Studycode001 <148090007+Studycode001@users.noreply.github.com>

add instrument in interface (sugarlabs#4503)

2ce0dcf

test suite for lilypond.js (sugarlabs#4504)

c83b96f

* test suite for lilypond.js * license

documentation information change regarding Firefox (sugarlabs#4507)

d197a73

Fixing no rendering of Play-Only-Mode (sugarlabs#4494)

bdc813a

Signed-off-by: Justin Charles <charlesjustin2124@gmail.com>

Change the download url for lilypond for linux and windows to point t…

cf1be6d

…o correct source

Add link to download lilypond for mac os

97bc882

Change the doc to contain one link for all os to downlaod lilypond

4c29905

add midi export (sugarlabs#4509)

49cf03d

test suite for js/Blocks/BooleanBlocks.js (sugarlabs#4517)

87d099f

* Adding test cases for BooleanBlocks.js * Exporting modules for test

Add Urdu Translation (sugarlabs#4524)

e3361b3

* Adding urdu translation in localization.ini * Adding urdu translation in ur.po

Ajeett01 and others added 26 commits April 29, 2025 08:33

Added Event Delegation (sugarlabs#4600)

5bf4a3b

Add frequency (Hz) display to Sampler Widget (sugarlabs#4616)

035da79

* Add frequency display to Sampler Widget * Fix pitch button * Use platformColor.textColor instead of hardcoded color --------- Co-authored-by: Anvita Prasad <cs23b1059.iiitdm.ac.in>

Timbre UI Fix (sugarlabs#4614)

3f8c6d7

* TimbreUI * linting * unused elements

Complete Portuguese (pt) translation (sugarlabs#4608)

060340e

Co-authored-by: Anvita Prasad <cs23b1059.iiitdm.ac.in>

update PT

d6d4ff0

Add documentation for frequency display in Sampler widget (sugarlabs#…

69c3104

…4622) * Add documentation for frequency display in Sampler widget * Update documentation to use A notes as examples --------- Co-authored-by: Anvita Prasad <cs23b1059.iiitdm.ac.in>

added tests for ToneBlocks.js file (sugarlabs#4612)

5b425ac

* edited * added tests for toneBlocks.js * fixed linting issues --------- Co-authored-by: Studycode001 <148090007+Studycode001@users.noreply.github.com>

add description for minified libs (sugarlabs#4624)

818d497

added test to mediaBlocks.js (sugarlabs#4577)

aa0e5a7

FIX: Timbre (effects) (sugarlabs#4623)

95d677b

* bug fixes * coment * singer fix * max value 1000 for base frequency

Improve test coverage for notation.js (sugarlabs#4628)

9c79b75

Co-authored-by: Anvita Prasad <cs23b1059.iiitdm.ac.in>

Add lang='en' attribute (sugarlabs#4635)

739e80c

Improve test coverage for background.js && languagebox.js (sugarlabs#…

b773fdb

…4629) * Enhance browser action tests for Firefox and Chrome environments * Improve test coverage for languagebox.js Signed-off-by: asim <aktech701@gmail.com> --------- Signed-off-by: asim <aktech701@gmail.com>

improved test coverage for drumactions.js (sugarlabs#4636)

a0f92b9

expanded coverage ornamentactions.js (sugarlabs#4639)

8e7b592

more test coverage for volumeactions.js (sugarlabs#4640)

ef1183f

fix(add): Improved test coverage for dictactions.js (sugarlabs#4637)

16af61d

* improved test coverage for js/turtleactions/dictactions.js * improved test coverage for js/turtleactions/dictactions.js

fix(add):added tests for meteractions.js (sugarlabs#4638)

adb0714

* added tests for meteractions.js * added tests for meteractions.js

new instrument - mandolin (sugarlabs#4581)

db0ea31

Resolving Test Failure (sugarlabs#4649)

df160ce

fix(add): Improved test coverage for pitchactions.js (sugarlabs#4648)

c9f1752

* added coverage for pitchactions.js * added coverage for pitchactions.js * added coverage for pitchactions.js * bumped test coverage for pitchactions.js * bumped test coverage for pitchactions.js

Improved accessibility: added alt and title to logo image (sugarlabs#…

910b58b

…4645) * Improved accessibility: added alt and title to logo image * fix: removed title attribute from amp-img

play chord in music keyboard (sugarlabs#4563)

a08bcdc

* play chord * semicolon added

rafactor from html4 to html5 (sugarlabs#4655)

c348b92

* rafactor from html4 to html5 * fixed wheelDiv's visibility * fixed the auxillary menu problem

Update Duff sample

b73890d

sa-fw-an closed this Apr 29, 2025

Uh oh!

Conversation

sa-fw-an commented Mar 5, 2025

Description

Users can access duff as shown in the video below:

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

sa-fw-an commented Mar 5, 2025

Uh oh!

walterbender commented Mar 5, 2025

Uh oh!

sa-fw-an commented Mar 5, 2025

Uh oh!

walterbender commented Mar 5, 2025

Uh oh!

pikurasa commented Mar 5, 2025

Uh oh!

pikurasa commented Mar 5, 2025

Uh oh!

sa-fw-an commented Mar 7, 2025

Uh oh!

haroon10725 commented Mar 8, 2025

Uh oh!

pikurasa commented Mar 10, 2025

Uh oh!

sa-fw-an commented Mar 11, 2025

Uh oh!

walterbender commented Mar 22, 2025

Uh oh!

walterbender commented Apr 23, 2025

Uh oh!

pikurasa commented Apr 24, 2025

Uh oh!

sa-fw-an commented Apr 25, 2025

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

sa-fw-an commented Apr 29, 2025

Uh oh!

sa-fw-an commented Apr 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants