test: add unit tests for statistics.js (Resubmission)#4972
test: add unit tests for statistics.js (Resubmission)#4972walterbender merged 1 commit intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
2 similar comments
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
800c2cd to
d8f8bd5
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
d8f8bd5 to
ef65b77
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
ef65b77 to
f5800b5
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
1853bd0 to
13ce9af
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
13ce9af to
a3670c8
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
a3670c8 to
be9db1e
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Hey @walterbender, I've gone ahead and bumped the coverage up to 100% across the board (statements, branches, functions, lines). Added tests for the parts that were missing — the onclose/onmaximize callbacks, the chart rendering callback in doAnalytics (both maximized and normal states), and more thorough checks on displayInfo output. 7 tests total, all passing. Rebased on latest master, single commit. Let me know if anything needs changing! |
Reason for Resubmission:
My previous PR #4970 was accidentally closed by a typo in another user's commit (3d56534) which said "Closes #4970" by mistake. My code was never merged.
Description
Added unit tests for
js/widgets/statistics.jsto verify thedisplayInfologic and improve code coverage.Changes
js/widgets/statistics.test.js.js/widgets/statistics.js.docById,Chart, andwidgetWindowsfor testing.Testing