Fix ReferenceError when doSearch is not yet available#5314
Closed
Kunal241207 wants to merge 1 commit intosugarlabs:masterfrom
Closed
Fix ReferenceError when doSearch is not yet available#5314Kunal241207 wants to merge 1 commit intosugarlabs:masterfrom
Kunal241207 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
Hey, I tested your changes and looked through the code. Everything looks good to me. |
kartikktripathi
approved these changes
Jan 25, 2026
Contributor
Author
|
Thanks a lot for the review! |
Contributor
|
Right, there's a load of other PRs open right now, hope yours will be checked and merged soon. |
Ashish-Rautela
suggested changes
Jan 31, 2026
Contributor
Ashish-Rautela
left a comment
There was a problem hiding this comment.
Search is not working after the changes
Contributor
|
Thanks for flagging this, good catch. I re-tested, and it looks like the new guard prevents the ReferenceError but can also skip initialising search entirely when |
Contributor
Author
|
Closing this PR since the issue has been resolved in #5676. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a ReferenceError that occurs when
doSearch()is invokedbefore it is available on page load.
In some load orders,
doSearchis defined later (e.g. underwindow.activity), causing the initial call in$(document).ready()to fail and stop further script execution.
The fix safely checks for
doSearchin both locations before callingit, preventing the error while preserving existing behavior.
Fixes #5313