Fix mobile widget responsiveness#5341
Closed
nishtha-agarwal-211 wants to merge 1 commit intosugarlabs:masterfrom
Closed
Fix mobile widget responsiveness#5341nishtha-agarwal-211 wants to merge 1 commit intosugarlabs:masterfrom
nishtha-agarwal-211 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Consolidate redundant mobile media queries and replace hard-coded pixel values with fluid sizing using clamp(). This prevents widget overflow on small screens and improves touch usability while keeping desktop behavior unchanged. Fixes sugarlabs#5321
nishtha-agarwal-211
force-pushed
the
fix-mobile-widget-responsiveness
branch
from
544cdc5 to
aa81dbf
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
@nishtha-agarwal-211 duplicate of PR #5322 .Please close this |
|
@nishtha-agarwal-211 Duplicate of PR #5322 .Please close |
Author
|
Thank you for pointing it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the mobile responsiveness of widget windows by consolidating redundant CSS breakpoints and introducing fluid sizing using
clamp().Changes
@media (max-width: 600px)Testing
Manually tested using browser DevTools:
Note
Inline width/height styles applied by the JS resizing logic may override mobile full-screen sizing if a window is resized on desktop and then switched to mobile. This behavior is unchanged and was intentionally left untouched to keep this PR scoped to CSS responsiveness only.
Fixes #5321