feat: non-blocking user feedback for clipboard copy failure#5750
feat: non-blocking user feedback for clipboard copy failure#5750ayushi-forge wants to merge 1 commit intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Thanks for the review on the earlier discussion in #5484. This PR implements the suggested user-facing, non-blocking feedback for clipboard |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
f052c92 to
4bef213
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
vanshika2720
left a comment
There was a problem hiding this comment.
@ayushi-forge The UX improvement looks good and the change is scoped correctly.
One concern:
ClipboardJS is instantiated inside copyURLToClipboard(). If this function runs multiple times, it may create multiple listeners. Please confirm this does not lead to duplicate handlers or memory leaks.
This PR addresses reviewer feedback from #5484.
Instead of a blocking alert() or console-only feedback, this adds a small,
non-blocking, temporary inline message near the copy trigger when clipboard
copy fails.
Related issue: #5483