Skip to content

feat: non-blocking user feedback for clipboard copy failure#5750

Open
ayushi-forge wants to merge 1 commit intosugarlabs:masterfrom
ayushi-forge:non-blocking-clipboard-feedback
Open

feat: non-blocking user feedback for clipboard copy failure#5750
ayushi-forge wants to merge 1 commit intosugarlabs:masterfrom
ayushi-forge:non-blocking-clipboard-feedback

Conversation

@ayushi-forge
Copy link

This PR addresses reviewer feedback from #5484.

Instead of a blocking alert() or console-only feedback, this adds a small,
non-blocking, temporary inline message near the copy trigger when clipboard
copy fails.

  • Improves UX without freezing the UI
  • Keeps feedback user-facing and non-intrusive
  • Prevents stacking messages on repeated clicks
  • Keeps scope minimal with no unrelated changes

Related issue: #5483

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@ayushi-forge
Copy link
Author

Thanks for the review on the earlier discussion in #5484.

This PR implements the suggested user-facing, non-blocking feedback for clipboard
copy failure while keeping the scope minimal. Happy to make any adjustments if needed.

@github-actions
Copy link
Contributor

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

RequestManager.test.js

@ayushi-forge ayushi-forge force-pushed the non-blocking-clipboard-feedback branch from f052c92 to 4bef213 Compare February 15, 2026 20:07
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

Copy link
Contributor

@vanshika2720 vanshika2720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayushi-forge The UX improvement looks good and the change is scoped correctly.
One concern:
ClipboardJS is instantiated inside copyURLToClipboard(). If this function runs multiple times, it may create multiple listeners. Please confirm this does not lead to duplicate handlers or memory leaks.

vanshika2720

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants