Skip to content

feat: non-blocking user feedback for clipboard copy failure #5750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayushi-forge wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: non-blocking user feedback for clipboard copy failure #5750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion planet/js/GlobalCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,27 @@ class GlobalCard {
this.ProjectData = this.Planet.GlobalPlanet.cache[id];
}
}
function showTemporaryCopyMessage(target, message) {
// Remove existing feedback if present
const existing = target.parentNode.querySelector(".copy-feedback");
if (existing) {
existing.remove();
}

const msg = document.createElement("span");
msg.textContent = message;
msg.className = "copy-feedback";

msg.style.marginLeft = "8px";
msg.style.fontSize = "12px";
msg.style.color = "#d32f2f"; // red for failure

target.parentNode.appendChild(msg);

setTimeout(() => {
msg.remove();
}, 2000);
}

function copyURLToClipboard() {
const clipboard = new ClipboardJS(".copyshareurl");
Expand All @@ -258,7 +279,7 @@ function copyURLToClipboard() {
});

clipboard.on("error", e => {
alert("Failed to copy!");
showTemporaryCopyMessage(e.trigger, "Failed to copy");
// eslint-disable-next-line no-console
console.error("Failed to copy:", e.action);
});
Expand Down
Loading