✅(export) add PDF regression tests #1762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +71 B (0%) Total Size: 4.16 MB
|
1 task
AntoLC
force-pushed
the
feat/export-regression-testing
branch
from
bcd975b to
9cb6bc1
Compare
AntoLC
force-pushed
the
feat/export-regression-testing
branch
from
9cb6bc1 to
2da302d
Compare
We improved the svg width calculation when the width attribute is undefined by trying to use the style attribute before falling back to a default value.
To avoid regression issues in PDF export functionality, this commit introduces end-to-end tests that compare exported PDFs against known good reference files. We compare the PDF on most of the blocks that the editor supports. If during a Blocknote release or pull request there are intentional changes, the reference files would need to be updated accordingly. It can be done by uncommenting the line in the test that saves the newly generated PDF to the assets folder.
The regression test is asserting most of the blocks of the editor, we can remove some redundant tests. We improved as well the odt and docx tests by overriding as well the document content like for pdf, it will assert more blocks and have less code to maintain.
Heading 4 5 6 in PDF were not correctly mapped to their corresponding styles in the exported document. The new export is now different than the regression pdf, we need to update the regression PDF to match the new correct export.
AntoLC
force-pushed
the
feat/export-regression-testing
branch
from
2da302d to
f9c9e44
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To avoid regression issues in PDF export functionality, this PR introduces end-to-end tests that compare exported PDFs against known good reference files.
We compare the PDF on most of the blocks that the editor supports.
docs/src/frontend/apps/e2e/__tests__/app-impress/doc-export.spec.ts
Lines 351 to 352 in bcd975b
Proposal
Demo
What we test
doc-export-regressions.pdf