-
Notifications
You must be signed in to change notification settings - Fork 102
refactor: new workspace crate #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current status / next todo:
copying (with acknowledgements) from biome to get things going
pg_markup
pg_console
pg_text_edit
pg_diagnostics_macros
pg_diagnostics_categories
pg_diagnostics
pg_configuration
will serve as a base to work on
pg_workspace_new
(to be renamed to pg_workspace later)pg_cli
goal of this pr is to be able to start and stop the daemon process and accept file changes, connect to the database and populate the schema cache. we can then start moving features over in follow-up prs.
we will use the same client-server architecture as biome, but with a few adaptions to make it work for postgres. the list is not complete, just thoughts gathered while working on this:
toml
format for the config file. it will contain only the db connection string for now, but the foundation for all sorts of configurations is laid out already.