Skip to content

go: Remove EventsPublic. it's not being used anywhere #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

svix-mman
Copy link
Contributor

This struct (EventsPublic) is not being used anywhere

And it's not possible to create this struct manually, because the client field is private. So I am sure this code is not being used

And it's not possible to create this struct manually, because the `client` field is private. So I am sure this code is not being used
@svix-mman svix-mman requested a review from a team as a code owner April 14, 2025 18:22
Copy link
Member

@svix-jplatte svix-jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this was left over from a previous spec version. It was never public. We likely have it for other languages too. For Rust, check with Owen whether the new public poller routes are usable in CLI before removing it there / in the Rust SDK.

@svix-mman svix-mman merged commit d705e76 into main Apr 14, 2025
11 checks passed
@svix-mman svix-mman deleted the mendy/remove-dead-code branch April 14, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants