Move SvixHttpClient
to internal package
#1884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done in preparation for the new internal API client
In Go, the
internal
package has special semantics. https://pkg.go.dev/cmd/go#hdr-Internal_DirectoriesSo we can define public method for our SDK to consume, but external packages wont be able to import the internal package
For example this is the error I get when trying to import the internal package in the TF provider
This is technically a breaking change, because the
svix.SvixHttpClient
struct will no longer be availableHowever, this is not an issue. Since there is no use in defining the
svix.SvixHttpClient
by hand, because the only use case it has is to be part of the resource structsBut a user of our SDK would not be define the
Application
struct, becauseclient
is not an exported field.