[C/C++] CMake: Add swiftnav::sbp alias target
#1534
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin4861
requested changes
Nov 14, 2025
| swift_add_library(sbp | ||
| SOURCES ${libsbp_SRCS} | ||
| ) | ||
| add_library(swiftnav::sbp ALIAS sbp) |
Contributor
There was a problem hiding this comment.
The alias name is already used internally for the tests.
I dug deeper into the definition of swift_add_library, which creates sbp and turned out, that it already does add_library(${SWIFTNAV_ALIAS}::${target} ALIAS ${target}) in the cmake common lib.
Therefore I would rather not add this line, but I would be fine, if you added a comment, stating, that the alias is already set using swift_add_library.
Contributor
Author
There was a problem hiding this comment.
Oh I totally missed that! As long as that target is there then I'm happy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/algint-team
Add an alias target
swiftnav::sbpfor the existingsbptarget.The alias target allows consumers building
libsbpwithin their file tree to link against the same target as consumers using an externally-builtlibsbp.Resolves #1531.
API compatibility
Does this change introduce a API compatibility risk?
No, the previous
sbptarget is still an option for in-tree consumers.API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
N/A
JIRA Reference
N/A