Skip to content

[C/C++] CMake: Add swiftnav::sbp alias target #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[C/C++] CMake: Add swiftnav::sbp alias target #1534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions c/src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ set(libsbp_SRCS
swift_add_library(sbp
SOURCES ${libsbp_SRCS}
)
add_library(swiftnav::sbp ALIAS sbp)
Copy link
Contributor

@martin4861 martin4861 Nov 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alias name is already used internally for the tests.

I dug deeper into the definition of swift_add_library, which creates sbp and turned out, that it already does add_library(${SWIFTNAV_ALIAS}::${target} ALIAS ${target}) in the cmake common lib.
Therefore I would rather not add this line, but I would be fine, if you added a comment, stating, that the alias is already set using swift_add_library.

Copy link
Contributor Author

@ethanmusser ethanmusser Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I totally missed that! As long as that target is there then I'm happy!


if(I_KNOW_WHAT_I_AM_DOING_AND_HOW_DANGEROUS_IT_IS__LIBSBP_DISABLE_CRC_VALIDATION)
target_compile_definitions(sbp PRIVATE LIBSBP_DISABLE_CRC_VALIDATION)
Expand Down
Loading