[lldb] Detect how the swift runtime stores currently executing task#13279
Draft
felipepiovezan wants to merge 4 commits into
Draft
[lldb] Detect how the swift runtime stores currently executing task#13279felipepiovezan wants to merge 4 commits into
felipepiovezan wants to merge 4 commits into
Conversation
felipepiovezan
force-pushed
the
felipe/embedded_work
branch
from
2e1870a to
522063c
Compare
This also removes an incorrect use of `#ifdef SWIFT_THREADING_USE_RESERVED_TLS_KEYS`. Such macro is meaningless for the host.
felipepiovezan
force-pushed
the
felipe/embedded_work
branch
from
522063c to
711a811
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second commit fixes a typo in the symbol used to detect whether we have a statically linked concurrency library.
The third and fourth commit change LLDB so that it reads from the concurrency runtime library itself how task pointers are stored, building on top of the work in swiftlang/swift#90290. This is still just NFC: helper functions and data structures are created, but no functionality changes.
The fifth commit creates an abstraction that can be extended for each of the different ways the current task pointer can be stored. It is in practice NFC, as no new way is supported.
This is a draft, as I want to validate this hypothesis on embedded swift and also on Linux, which use different approaches than on non-embedded/macos targets