[Concurrency] Add _concurrency_current_task_storage_kind to Debug.h#90290
Open
felipepiovezan wants to merge 2 commits into
Open
[Concurrency] Add _concurrency_current_task_storage_kind to Debug.h#90290felipepiovezan wants to merge 2 commits into
felipepiovezan wants to merge 2 commits into
Conversation
…on in static linked libs This symbol is currently removed by the linker on static builds e.g. in embedded swift or linux.
felipepiovezan
commented
Jun 30, 2026
| #include "ExecutorBridge.h" | ||
| #include "TaskPrivate.h" | ||
| #include "swift/ABI/Actor.h" | ||
| #include "swift/ABI/Task.h" |
Contributor
Author
There was a problem hiding this comment.
this is clang-format's doing..
Contributor
|
@swift-ci please smoke test |
al45tair
approved these changes
Jul 1, 2026
al45tair
left a comment
al45tair
left a comment
Contributor
There was a problem hiding this comment.
I did briefly wonder whether we should just have an API for the debugger to call, though of course that means doing a call in the inferior, which is a lot more expensive than just poking about in its memory.
Contributor
Author
Yeah, actually I should have linked a post on the forums about this. Let me quote what I said there:
(https://forums.swift.org/t/exploring-multicore-concurrency-for-embedded-swift/87129/10) |
Contributor
Author
I need to update this test |
This variable is used to tell the debugger how the runtime stores the currently executing task. Prior to this patch, the debugger has no way of knowing how the concurrency library was configured for the target, as this is a build-time decision; as a result, it is forced to assume the "common" configuration of swift for macos targets. Bumping the concurrency version number is not necessary, as this is not changing the debug ABI in any way. The debugger can simply test the presence of the symbol.
felipepiovezan
force-pushed
the
felipe/concurrency_task_storage
branch
from
2027c96 to
a81d13d
Compare
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
Compiler seems broken: |
Contributor
Author
|
@swift-ci smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is required for swiftlang/llvm-project#13279